feat(operator): eliminate the Remove User button (#5238)

**CLOUD ONLY**

The Remove User button on the operator Accounts page actually removes the user from an organization, not an account. When there was a 1:1 mapping between accounts and orgs, this was fine, but we are now moving into a multi-org world where this no longer makes sense.

We need to do more significant work to the operator UI to support multi-org, and this work will happen in a later phase of the project.

For now, given that there is a feature in the main part of the UI where users can remove themselves or other users from an organzation, we've decided to remove the `Remove User` button.

This is the only client of `ResourcesTableRow` that passed additional `children`, and I believe that ability was added as a bit of hack to support this one use case. Therefore, I also removed the `children` prop from `ResourcesTableRow` as dead code. Should we need it again in the future, it should be relatively easy to add back.

Author: Randy Coulman

src/operator/ResourcesTableRow.tsx

@@ -11,7 +11,7 @@ interface Props {
 const resolvePath = (object, path, defaultValue) =>
   path.split('.').reduce((o, p) => (o ? o[p] : defaultValue), object)
 
-const ResourcesTableRow: FC<Props> = ({children, resource, infos}) => {
+const ResourcesTableRow: FC<Props> = ({resource, infos}) => {
   const returnValue = (path, defaultValue, renderValue) => {
     const value = resolvePath(resource, path, defaultValue)
     return renderValue ? renderValue(value) : value
@@ -24,7 +24,6 @@ const ResourcesTableRow: FC<Props> = ({children, resource, infos}) => {
           {returnValue(path, defaultValue, renderValue)}
         </Table.Cell>
       ))}
-      {children}
     </Table.Row>
   )
 }

src/operator/account/AssociatedUsersTable.tsx

@@ -10,19 +10,15 @@ import {
 
 // Components
 import ResourcesTableRow from 'src/operator/ResourcesTableRow'
-import RemoveFromAccount from 'src/operator/account/RemoveFromAccount'
 
 // Constants
 import {acctUserColumnInfo, accountUserHeaderInfo} from 'src/operator/constants'
 
 // Contexts
 import {AccountContext} from 'src/operator/context/account'
-import {OperatorContext} from 'src/operator/context/operator'
 
 const AssociatedTableUsers: FC = () => {
-  const {account, handleRemoveUserFromAccount} = useContext(AccountContext)
-  const hasMultipleUsers = account?.users?.length > 1
-  const {hasWritePermissions} = useContext(OperatorContext)
+  const {account} = useContext(AccountContext)
 
   return (
     <FlexBox direction={FlexDirection.Column} margin={ComponentSize.Large}>
@@ -41,15 +37,7 @@ const AssociatedTableUsers: FC = () => {
                 key={resource.id}
                 resource={resource}
                 infos={acctUserColumnInfo}
-              >
-                {hasWritePermissions && hasMultipleUsers && (
-                  <RemoveFromAccount
-                    removeUser={async () => {
-                      await handleRemoveUserFromAccount(resource.id)
-                    }}
-                  />
-                )}
-              </ResourcesTableRow>
+              />
             ))}
           </Table.Body>
           <Table.Footer />

src/operator/account/RemoveFromAccount.tsx

@@ -8,7 +8,6 @@ import {
   patchOperatorAccountsConvert,
   deleteOperatorAccount,
   getOperatorAccount,
-  deleteOperatorAccountsUser,
 } from 'src/client/unityRoutes'
 import {notify} from 'src/shared/actions/notifications'
 import {
@@ -32,7 +31,6 @@ export interface AccountContextType {
   handleConvertAccountToContract: (contractStartDate: string) => void
   handleDeleteAccount: () => void
   handleGetAccount: () => void
-  handleRemoveUserFromAccount: (id: string) => void
   organizations: OperatorOrg[]
   setConvertToContractOverlayVisible: (vis: boolean) => void
   convertToContractOverlayVisible: boolean
@@ -48,7 +46,6 @@ export const DEFAULT_CONTEXT: AccountContextType = {
   handleConvertAccountToContract: () => {},
   handleDeleteAccount: () => {},
   handleGetAccount: () => {},
-  handleRemoveUserFromAccount: (_: string) => {},
   organizations: null,
   setConvertToContractOverlayVisible: (_: boolean) => {},
   convertToContractOverlayVisible: false,
@@ -139,28 +136,6 @@ export const AccountProvider: FC<Props> = React.memo(({children}) => {
     }
   }, [dispatch, history, accountID])
 
-  const handleRemoveUserFromAccount = useCallback(
-    async (userID: string) => {
-      try {
-        setDeleteStatus(RemoteDataState.Loading)
-        const resp = await deleteOperatorAccountsUser({
-          accountId: accountID,
-          userId: userID,
-        })
-        if (resp.status !== 204) {
-          throw new Error(resp.data.message)
-        }
-        setDeleteStatus(RemoteDataState.Done)
-      } catch (error) {
-        console.error({error})
-        dispatch(notify(deleteAccountError(accountID)))
-      } finally {
-        await handleGetAccount()
-      }
-    },
-    [dispatch, handleGetAccount, accountID]
-  )
-
   return (
     <AccountContext.Provider
       value={{
@@ -171,7 +146,6 @@ export const AccountProvider: FC<Props> = React.memo(({children}) => {
         handleConvertAccountToContract,
         handleDeleteAccount,
         handleGetAccount,
-        handleRemoveUserFromAccount,
         organizations,
         setConvertToContractOverlayVisible,
         convertToContractOverlayVisible,