Skip to content

Commit 459d12b

Browse files
authored
fix: update save script text (#5857)
Co-authored-by: drdelambre <drdelambre>
1 parent 5793a55 commit 459d12b

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

src/dataExplorer/components/SaveAsScript.tsx

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,17 @@ const SaveAsScript: FC<Props> = ({onClose, type}) => {
113113
let overlayTitle = 'Save Script'
114114

115115
if (type !== OverlayType.SAVE) {
116-
overlayTitle = 'Do you want to save your Script first?'
116+
if (resource?.data?.id && hasChanged) {
117+
overlayTitle = 'Do you want to save your changes first?'
118+
} else {
119+
overlayTitle = 'Do you want to save your script first?'
120+
}
117121
}
118122

119123
if (!hasChanged && type === OverlayType.OPEN) {
120124
return <OpenScript onCancel={handleClose} onClose={onClose} />
121125
}
122126

123-
const displayWarning =
124-
(type === OverlayType.NEW && !resource?.data?.name) ||
125-
(type === OverlayType.OPEN && !resource?.data?.name) ||
126-
(type === OverlayType.OPEN && hasChanged && resource?.data?.id)
127-
128127
let saveText = 'Save'
129128

130129
if (resource?.data?.id) {
@@ -142,15 +141,9 @@ const SaveAsScript: FC<Props> = ({onClose, type}) => {
142141
}
143142

144143
return (
145-
<Overlay.Container maxWidth={500}>
144+
<Overlay.Container maxWidth={540}>
146145
<Overlay.Header title={overlayTitle} onDismiss={handleClose} />
147146
<Overlay.Body>
148-
{displayWarning && (
149-
<div className="save-script-overlay__warning-text">
150-
"{resource?.data?.name ?? 'Untitled Script'}" will be overwritten by
151-
a new one if you don’t save it.
152-
</div>
153-
)}
154147
<Form>
155148
<InputLabel>Save as</InputLabel>
156149
<Input

0 commit comments

Comments
 (0)