feat(idpe-15219): remove pinned items from Tasks (#5784)

Author: wiedld

src/tasks/components/TaskCard.test.tsx

@@ -30,7 +30,6 @@ const setup = (override = {}) => {
     labels: [], // all labels
     onPinTask: jest.fn(),
     onUnpinTask: jest.fn(),
-    isPinned: false,
     org: {id: 'BUCKSINSIX', name: 'Milwaukee Bucks'},
     me: {
       id: 'FORTHECULTURE',

src/tasks/components/TaskCard.tsx

@@ -3,11 +3,6 @@ import React, {PureComponent, RefObject, createRef} from 'react'
 import {connect, ConnectedProps} from 'react-redux'
 import {withRouter, RouteComponentProps} from 'react-router-dom'
 
-import {
-  deletePinnedItemByParam,
-  updatePinnedItemByParam,
-} from 'src/shared/contexts/pinneditems'
-
 // Components
 import {
   SlideToggle,
@@ -40,12 +35,8 @@ import {Task, Label} from 'src/types'
 // Constants
 import {DEFAULT_TASK_NAME} from 'src/dashboards/constants'
 import {isFlagEnabled} from 'src/shared/utils/featureFlag'
-import {CLOUD} from 'src/shared/constants'
 
-import {
-  pinnedItemFailure,
-  pinnedItemSuccess,
-} from 'src/shared/copy/notifications'
+// Utils
 import {notify} from 'src/shared/actions/notifications'
 import {downloadTaskTemplate} from 'src/tasks/apis'
 import {event} from 'src/cloud/utils/reporting'
@@ -60,9 +51,6 @@ interface PassedProps {
   onRunTask: (taskID: string) => void
   onUpdate: (name: string, taskID: string) => void
   onFilterChange: (searchTerm: string) => void
-  onPinTask: (taskID: string, name: string) => void
-  onUnpinTask: (taskID: string) => void
-  isPinned: boolean
 }
 
 type ReduxProps = ConnectedProps<typeof connector>
@@ -147,26 +135,12 @@ export class TaskCard extends PureComponent<
     )
   }
 
-  private handlePinTask = () => {
-    const {task, isPinned} = this.props
-
-    if (isPinned) {
-      this.props.onUnpinTask(task.id)
-    } else {
-      this.props.onPinTask(task.id, task.name)
-    }
-  }
-
-  private handleOnDelete = async task => {
+  private handleOnDelete = task => {
     this.props.onDelete(task)
-    try {
-      await deletePinnedItemByParam(task.id)
-    } catch (error) {
-      this.props.sendNotification(pinnedItemFailure(error.message, 'delete'))
-    }
   }
+
   private get contextMenu(): JSX.Element {
-    const {task, onClone, isPinned} = this.props
+    const {task, onClone} = this.props
     const settingsRef: RefObject<HTMLButtonElement> = createRef()
 
     return (
@@ -194,7 +168,7 @@ export class TaskCard extends PureComponent<
           appearance={Appearance.Outline}
           enableDefaultStyles={false}
           style={{minWidth: '112px'}}
-          contents={onHide => (
+          contents={_ => (
             <List>
               <List.Item
                 onClick={this.handleExport}
@@ -230,19 +204,6 @@ export class TaskCard extends PureComponent<
               >
                 Clone
               </List.Item>
-              {isFlagEnabled('pinnedItems') && CLOUD && (
-                <List.Item
-                  onClick={() => {
-                    this.handlePinTask()
-                    onHide()
-                  }}
-                  size={ComponentSize.Small}
-                  style={{fontWeight: 500}}
-                  testID="context-pin-task"
-                >
-                  {isPinned ? 'Unpin' : 'Pin'}
-                </List.Item>
-              )}
             </List>
           )}
           triggerRef={settingsRef}
@@ -302,14 +263,6 @@ export class TaskCard extends PureComponent<
       task: {id},
     } = this.props
     onUpdate(name, id)
-    if (isFlagEnabled('pinnedItems') && CLOUD && this.props.isPinned) {
-      try {
-        updatePinnedItemByParam(id, {name})
-        this.props.sendNotification(pinnedItemSuccess('task', 'updated'))
-      } catch (err) {
-        this.props.sendNotification(pinnedItemFailure(err.message, 'update'))
-      }
-    }
   }
 
   private handleExport = () => {

src/tasks/components/TasksList.tsx

@@ -22,34 +22,16 @@ import {getSortedResources} from 'src/shared/utils/sort'
 import {getMe} from 'src/me/selectors'
 import {getOrg} from 'src/organizations/selectors'
 
-// Contexts
-import {
-  addPinnedItem,
-  deletePinnedItemByParam,
-  PinnedItemTypes,
-} from 'src/shared/contexts/pinneditems'
-
 // Utils
 import {event} from 'src/cloud/utils/reporting'
 import {isFlagEnabled} from 'src/shared/utils/featureFlag'
-import {CLOUD} from 'src/shared/constants'
 import {notify} from 'src/shared/actions/notifications'
 
 // Constants
 import {GLOBAL_HEADER_HEIGHT} from 'src/identity/components/GlobalHeader/constants'
 
 import {PaginationNav} from '@influxdata/clockface'
 
-import {
-  pinnedItemFailure,
-  pinnedItemSuccess,
-} from 'src/shared/copy/notifications'
-
-let getPinnedItems
-if (CLOUD) {
-  getPinnedItems = require('src/shared/contexts/pinneditems').getPinnedItems
-}
-
 interface OwnProps {
   pageHeight: number
   pageWidth: number
@@ -74,7 +56,6 @@ interface OwnProps {
 interface State {
   taskLabelsEdit: Task
   isEditingTaskLabels: boolean
-  pinnedItems: any[]
 }
 
 type ReduxProps = ConnectedProps<typeof connector>
@@ -86,7 +67,6 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
   private memGetSortedResources =
     memoizeOne<typeof getSortedResources>(getSortedResources)
 
-  private isComponentMounted: boolean
   private paginationRef: RefObject<HTMLDivElement>
 
   public currentPage: number = 1
@@ -98,14 +78,12 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
     this.state = {
       taskLabelsEdit: null,
       isEditingTaskLabels: false,
-      pinnedItems: [],
     }
 
     this.paginationRef = createRef<HTMLDivElement>()
   }
 
   public componentDidMount() {
-    this.isComponentMounted = true
     const params = new URLSearchParams(window.location.search)
     const urlPageNumber = parseInt(params.get('page'), 10)
 
@@ -116,9 +94,6 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
     }
 
     this.props.checkTaskLimits()
-    if (CLOUD && isFlagEnabled('pinnedItems')) {
-      this.updatePinnedItems()
-    }
   }
 
   public componentDidUpdate() {
@@ -129,10 +104,6 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
     }
   }
 
-  public componentWillUnmount() {
-    this.isComponentMounted = false
-  }
-
   public render() {
     const heightWithPagination =
       this.paginationRef?.current?.clientHeight ||
@@ -175,48 +146,6 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
     )
   }
 
-  public updatePinnedItems = () => {
-    getPinnedItems()
-      .then(res => {
-        if (this.isComponentMounted) {
-          this.setState(prev => ({...prev, pinnedItems: res}))
-        }
-      })
-      .catch(err => console.error(err))
-  }
-
-  public handlePinTask = async (taskID: string, name: string) => {
-    const {org, me} = this.props
-
-    // add to pinned item list
-    try {
-      await addPinnedItem({
-        orgID: org.id,
-        userID: me.id,
-        metadata: {
-          taskID,
-          name,
-        },
-        type: PinnedItemTypes.Task,
-      })
-      this.props.sendNotification(pinnedItemSuccess('task', 'added'))
-      this.updatePinnedItems()
-    } catch (err) {
-      this.props.sendNotification(pinnedItemFailure(err.message, 'add'))
-    }
-  }
-
-  public handleUnpinTask = async (taskID: string) => {
-    // delete from pinned item list
-    try {
-      await deletePinnedItemByParam(taskID)
-      this.props.sendNotification(pinnedItemSuccess('task', 'deleted'))
-      this.updatePinnedItems()
-    } catch (err) {
-      this.props.sendNotification(pinnedItemFailure(err.message, 'delete'))
-    }
-  }
-
   public paginate = page => {
     this.currentPage = page
     const url = new URL(location.href)
@@ -260,14 +189,6 @@ class TasksList extends PureComponent<Props, State> implements Pageable {
             onUpdate={this.props.onUpdate}
             onRunTask={this.props.onRunTask}
             onFilterChange={this.props.onFilterChange}
-            onPinTask={this.handlePinTask}
-            onUnpinTask={this.handleUnpinTask}
-            isPinned={
-              this.state.pinnedItems?.length &&
-              !!this.state.pinnedItems.find(
-                item => item?.metadata.taskID === task.id
-              )
-            }
           />
         )
       }

src/tasks/containers/TasksPage.test.tsx

@@ -60,19 +60,6 @@ jest.mock('src/languageSupport/languages/flux/parser', () => ({
   format_from_js_file: jest.fn(),
 }))
 
-jest.mock('src/shared/contexts/pinneditems', () => ({
-  getPinnedItems: jest.fn(() =>
-    Promise.resolve({
-      json: () => Promise.resolve([]),
-    })
-  ),
-  PinnedItemTypes: {Task: 'task'},
-  addPinnedItem: jest.fn(() => {
-    return new Promise(resolve => resolve())
-  }),
-  deletePinnedItemByParam: jest.fn(() => Promise.resolve()),
-}))
-
 jest.mock('src/client', () => ({
   getTasks: jest.fn(() => {
     return {