fix: use "T" separator in time format placeholder to accomodate Safari (#3622)

Author: TCL735

src/utils/datetime/formatters.test.ts

@@ -419,6 +419,50 @@ describe('the DateTime formatter', () => {
         date.toISOString()
       }).not.toThrow()
     })
+
+    it('can use the T as a separator', () => {
+      let convertedDateString = convertDateToRFC3339(
+        new Date('2022-01-18T17:30:00Z'),
+        'Local'
+      )
+      let date = new Date(convertedDateString)
+      expect(date.toDateString()).not.toEqual('Invalid Date')
+      expect(() => {
+        date.toISOString()
+      }).not.toThrow()
+
+      convertedDateString = convertDateToRFC3339(
+        new Date('2022-01-19T01:30:00-0800'),
+        'UTC'
+      )
+      date = new Date(convertedDateString)
+      expect(date.toDateString()).not.toEqual('Invalid Date')
+      expect(() => {
+        date.toISOString()
+      }).not.toThrow()
+    })
+
+    it('can use space as a separator', () => {
+      let convertedDateString = convertDateToRFC3339(
+        new Date('2022-01-18 17:30:00Z'),
+        'Local'
+      )
+      let date = new Date(convertedDateString)
+      expect(date.toDateString()).not.toEqual('Invalid Date')
+      expect(() => {
+        date.toISOString()
+      }).not.toThrow()
+
+      convertedDateString = convertDateToRFC3339(
+        new Date('2022-01-19 01:30:00-0800'),
+        'UTC'
+      )
+      date = new Date(convertedDateString)
+      expect(date.toDateString()).not.toEqual('Invalid Date')
+      expect(() => {
+        date.toISOString()
+      }).not.toThrow()
+    })
   })
 })
 

src/utils/datetime/formatters.ts

@@ -804,7 +804,7 @@ export const convertDateToRFC3339 = (date: Date, timeZone: string): string => {
     const localTime = timeStringParsed[0]
     const utcOffset = timeStringParsed[1].replace('GMT', '')
 
-    return `${year}-${month}-${dayOfMonth} ${localTime}${utcOffset}`
+    return `${year}-${month}-${dayOfMonth}T${localTime}${utcOffset}`
   }
   return date.toISOString()
 }

src/visualization/components/internal/TimeTickInput.tsx

@@ -67,7 +67,7 @@ export const TimeTickInput: FC<TimeTickInputProps> = props => {
     tickPropertyName,
     tickOptions,
     initialTickOptionValue,
-    dateFormatPlaceholder = 'RFC 3339 or YYYY-MM-DD HH:MM:SSZ',
+    dateFormatPlaceholder = 'RFC 3339 or YYYY-MM-DDTHH:mm:ssZ',
     update,
   } = props