Skip to content

Commit 61a181c

Browse files
authored
fix(updateBucket): set labels to [] if reponse is null (#5447)
1 parent 1c675f1 commit 61a181c

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/buckets/actions/thunks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export const updateBucket = (bucket: OwnBucket) => async (
225225
}
226226

227227
const newBucket = normalize<Bucket, BucketEntities, string>(
228-
Object.assign(resp.data, {labels: labelsResponse.data.labels}),
228+
Object.assign(resp.data, {labels: labelsResponse.data.labels || []}),
229229
bucketSchema
230230
)
231231

src/shared/components/inlineLabels/InlineLabels.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,7 @@ class InlineLabels extends Component<Props> {
114114

115115
const mstp = (state: AppState, props: OwnProps) => {
116116
const labels = getAll<Label>(state, ResourceType.Labels)
117-
118-
let selectedLabels = []
119-
if (props.selectedLabelIDs) {
120-
selectedLabels = getLabels(state, props.selectedLabelIDs)
121-
}
117+
const selectedLabels = getLabels(state, props.selectedLabelIDs)
122118

123119
return {labels, selectedLabels}
124120
}

0 commit comments

Comments
 (0)