fix: only show pinned item notification if an item is pinned (#4042)

Author: appletreeisyellow

src/dashboards/components/dashboard_index/DashboardCard.tsx

@@ -126,7 +126,7 @@ class DashboardCard extends PureComponent<Props> {
 
     onUpdateDashboard(id, {name})
 
-    if (isFlagEnabled('pinnedItems') && CLOUD) {
+    if (isFlagEnabled('pinnedItems') && CLOUD && this.props.isPinned) {
       try {
         updatePinnedItemByParam(id, {name})
         this.props.sendNotification(pinnedItemSuccess('dashboard', 'updated'))
@@ -251,10 +251,12 @@ class DashboardCard extends PureComponent<Props> {
     const {id, onUpdateDashboard} = this.props
 
     onUpdateDashboard(id, {description})
-    try {
-      updatePinnedItemByParam(id, {description})
-    } catch (err) {
-      this.props.sendNotification(pinnedItemFailure(err.message, 'update'))
+    if (isFlagEnabled('pinnedItems') && CLOUD && this.props.isPinned) {
+      try {
+        updatePinnedItemByParam(id, {description})
+      } catch (err) {
+        this.props.sendNotification(pinnedItemFailure(err.message, 'update'))
+      }
     }
   }
 

src/flows/components/FlowCard.tsx

@@ -46,7 +46,7 @@ const FlowCard: FC<Props> = ({id, isPinned}) => {
 
   const handleRenameNotebook = (name: string) => {
     update(id, {...flow, name})
-    if (isFlagEnabled('pinnedItems') && CLOUD) {
+    if (isFlagEnabled('pinnedItems') && CLOUD && isPinned) {
       try {
         updatePinnedItemByParam(id, {name})
         dispatch(notify(pinnedItemSuccess('notebook', 'updated')))

src/tasks/components/TaskCard.tsx

@@ -276,7 +276,7 @@ export class TaskCard extends PureComponent<
       task: {id},
     } = this.props
     onUpdate(name, id)
-    if (isFlagEnabled('pinnedItems') && CLOUD) {
+    if (isFlagEnabled('pinnedItems') && CLOUD && this.props.isPinned) {
       try {
         updatePinnedItemByParam(id, {name})
         this.props.sendNotification(pinnedItemSuccess('task', 'updated'))