Skip to content

Commit 63eb821

Browse files
authored
fix: remove old token linking (#3900)
1 parent 6087fe2 commit 63eb821

File tree

3 files changed

+33
-78
lines changed

3 files changed

+33
-78
lines changed

cypress/e2e/shared/flowsSidebarExportToClipboard.test.ts

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import {Authorization} from 'src/client'
21
import {Organization} from 'src/types'
32

43
const openCopyAs = () => {
@@ -45,10 +44,6 @@ const verifyClientCode = (client: any) => {
4544
.scrollIntoView()
4645
.click()
4746

48-
cy.getByTestID('code-snippet')
49-
.children()
50-
.find('code')
51-
.contains(client.token)
5247
cy.getByTestID('code-snippet')
5348
.children()
5449
.find('code')
@@ -61,71 +56,60 @@ const verifyClientCode = (client: any) => {
6156
cy.get('.cf-overlay--dismiss').click()
6257
}
6358

64-
const getClients = (org: string, token: string, query: string) => {
59+
const getClients = (org: string, query: string) => {
6560
return [
6661
{
6762
name: 'arduino',
68-
token: `"<INFLUX_TOKEN>"`,
6963
org: `"${org}"`,
7064
query: query.replace(/"/g, '\\"'),
7165
},
7266
{
7367
name: 'csharp',
74-
token: `const string token = "${token}";`,
7568
org: `const string org = "${org}";`,
7669
query: query.replace(/"/g, '""'),
7770
},
7871
{
7972
name: 'go',
80-
token: `"${token}"`,
8173
org: `client.QueryAPI("${org}")`,
8274
query,
8375
},
8476
{
8577
name: 'java',
86-
token: `String token = "${token}";`,
8778
org: `String org = "${org}";`,
8879
query: query.replace(/"/g, '\\"'),
8980
},
9081
{
9182
name: 'javascript-node',
92-
token: `const token = '${token}'`,
9383
org: `const org = '${org}'`,
9484
query,
9585
},
9686
{
9787
name: 'kotlin',
98-
token: `val token = "${token}"`,
9988
org: `val org = "${org}"`,
10089
query,
10190
},
10291
{
10392
name: 'php',
104-
token: `$token = '${token}';`,
10593
org: `$org = '${org}';`,
10694
query: query.replace(/"/g, '\\"'),
10795
},
10896
{
10997
name: 'python',
110-
token: `token = "${token}"`,
11198
org: `org = "${org}"`,
11299
query,
113100
},
114101
{
115102
name: 'ruby',
116-
token: `token = '${token}'`,
117103
org: `org = '${org}'`,
118104
query,
119105
},
120106
{
121107
name: 'scala',
122-
token: `val token = "${token}"`,
123108
org: `val org = "${org}"`,
124109
query,
125110
},
126111
{
127112
name: 'swift',
128-
token: `let token = "${token}"`,
129113
org: `let org = "${org}"`,
130114
query,
131115
},
@@ -140,9 +124,6 @@ describe('Flows', () => {
140124
cy.signin()
141125
cy.get('@org').then(({id}: Organization) => {
142126
cy.fixture('routes').then(({orgs}) => {
143-
cy.request('api/v2/authorizations').then(({body}) => {
144-
cy.wrap(body.authorizations).as('tokens')
145-
})
146127
cy.visit(`${orgs}/${id}`)
147128
})
148129
})
@@ -159,10 +140,8 @@ describe('Flows', () => {
159140
openCopyAs()
160141

161142
cy.get('@org').then(({name}: Organization) => {
162-
cy.get<Authorization[]>('@tokens').then(tokens => {
163-
getClients(name, tokens[0].token, query).forEach(client => {
164-
verifyClientCode(client)
165-
})
143+
getClients(name, query).forEach(client => {
144+
verifyClientCode(client)
166145
})
167146
})
168147
})
@@ -176,10 +155,8 @@ describe('Flows', () => {
176155
openCopyAs()
177156

178157
cy.get('@org').then(({name}: Organization) => {
179-
cy.get<Authorization[]>('@tokens').then(tokens => {
180-
getClients(name, tokens[0].token, query).forEach(client => {
181-
verifyClientCode(client)
182-
})
158+
getClients(name, query).forEach(client => {
159+
verifyClientCode(client)
183160
})
184161
})
185162
})

src/writeData/components/ClientCodeCopyPage/index.tsx

Lines changed: 16 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,9 @@ import InstallPackageHelper from 'src/writeData/components/ClientCodeCopyPage/In
99
// Constants
1010
import {CLIENT_DEFINITIONS} from 'src/writeData'
1111

12-
// Types
13-
import {ResourceType} from 'src/types'
14-
1512
// Styles
1613
import 'src/writeData/components/WriteDataDetailsView.scss'
1714

18-
// Utils
19-
import GetResources from 'src/resources/components/GetResources'
20-
2115
const codeRenderer: any = (props: any): any => {
2216
return <CodeSnippet text={props.value} label={props.language} />
2317
}
@@ -35,28 +29,24 @@ const ClientCodeCopyPage: FC<Props> = ({contentID, onCopy}) => {
3529
sampleCode = `${def.executeFull}`
3630
}
3731
return (
38-
<GetResources
39-
resources={[ResourceType.Authorizations, ResourceType.Buckets]}
40-
>
41-
<div className="write-data--details">
42-
<div
43-
className="write-data--details-content markdown-format"
44-
data-testid="load-data-details-content"
45-
>
46-
{!!def.description && (
47-
<InstallPackageHelper
48-
text={def.description}
49-
codeRenderer={codeRenderer}
50-
/>
51-
)}
52-
<CodeSampleBlock
53-
name="Initialize and Execute Flux"
54-
sample={sampleCode}
55-
onCopy={onCopy}
32+
<div className="write-data--details">
33+
<div
34+
className="write-data--details-content markdown-format"
35+
data-testid="load-data-details-content"
36+
>
37+
{!!def.description && (
38+
<InstallPackageHelper
39+
text={def.description}
40+
codeRenderer={codeRenderer}
5641
/>
57-
</div>
42+
)}
43+
<CodeSampleBlock
44+
name="Initialize and Execute Flux"
45+
sample={sampleCode}
46+
onCopy={onCopy}
47+
/>
5848
</div>
59-
</GetResources>
49+
</div>
6050
)
6151
}
6252

src/writeData/components/WriteDataDetailsContext.tsx

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,21 @@ import {getAll} from 'src/resources/selectors'
1717
import {getOrg} from 'src/organizations/selectors'
1818

1919
// Types
20-
import {AppState, ResourceType, Bucket, Authorization} from 'src/types'
20+
import {AppState, ResourceType, Bucket} from 'src/types'
21+
22+
const DEFAULT_TOKEN = '<INFLUX_TOKEN>'
23+
const DEFAULT_BUCKET = '<BUCKET>'
2124

2225
interface WriteDataDetailsContextType {
2326
bucket: Bucket
2427
changeBucket: (bucket: Bucket) => void
25-
token: Authorization
26-
changeToken: (token: Authorization) => void
2728
query: string
2829
changeQuery: (query: string) => void
2930
}
3031

3132
export const DEFAULT_WRITE_DATA_DETAILS_CONTEXT: WriteDataDetailsContextType = {
3233
bucket: null,
3334
changeBucket: () => {},
34-
token: null,
35-
changeToken: () => {},
3635
query: null,
3736
changeQuery: () => {},
3837
}
@@ -44,33 +43,26 @@ const WriteDataDetailsProvider: FC = ({children}) => {
4443
const buckets = useSelector((state: AppState) =>
4544
getAll<Bucket>(state, ResourceType.Buckets).filter(b => b.type === 'user')
4645
)
47-
const tokens = useSelector((state: AppState) =>
48-
getAll<Authorization>(state, ResourceType.Authorizations)
49-
)
50-
const org = useSelector(getOrg)
5146
const bucketname = useSelector(
5247
(state: AppState) => state.dataLoading?.steps?.bucket
5348
)
49+
const org = useSelector(getOrg)
5450
const server = window.location.origin
5551
const toLoadBucket = buckets?.find(b => b.name === bucketname)
5652
const [bucket, setBucket] = useState(
57-
toLoadBucket ?? buckets[0] ?? ({name: '<BUCKET>'} as Bucket)
53+
toLoadBucket ?? buckets[0] ?? ({name: DEFAULT_BUCKET} as Bucket)
5854
)
59-
const [token, setToken] = useState(tokens[0] ?? {token: '<INFLUX_TOKEN>'})
6055
const [query, setQuery] = useState(null)
6156

6257
const changeBucket = useCallback(
6358
(toChangeBucket: Bucket) => setBucket(toChangeBucket),
6459
[setBucket]
6560
)
61+
6662
const changeQuery = useCallback(
6763
(toChangeQuery: string) => setQuery(toChangeQuery),
6864
[setQuery]
6965
)
70-
const changeToken = useCallback(
71-
(toChangeToken: Authorization) => setToken(toChangeToken),
72-
[setToken]
73-
)
7466

7567
useEffect(() => {
7668
const _query = transform(query, variables)
@@ -106,28 +98,24 @@ const WriteDataDetailsProvider: FC = ({children}) => {
10698
}
10799
update({
108100
...variables,
109-
bucket: bucket.name,
101+
bucket: bucket?.name,
110102
})
111-
}, [variables, bucket?.name, bucket, update])
112-
103+
}, [variables, update, bucket])
113104
useEffect(() => {
114-
if (token?.token === variables.token) {
105+
if (DEFAULT_TOKEN === variables.token) {
115106
return
116107
}
117-
118108
update({
119109
...variables,
120-
token: token.token,
110+
token: DEFAULT_TOKEN,
121111
})
122-
}, [variables, token?.token, token, update])
112+
}, [variables, update])
123113

124114
return (
125115
<WriteDataDetailsContext.Provider
126116
value={{
127117
bucket,
128118
changeBucket,
129-
token,
130-
changeToken,
131119
query,
132120
changeQuery,
133121
}}

0 commit comments

Comments
 (0)