fix(5886): FluxEditor submit should not use memoized version of script (#5897)

Author: wiedld

src/dataExplorer/components/ResultsPane.tsx

@@ -1,5 +1,5 @@
 // Libraries
-import React, {FC, lazy, Suspense, useContext} from 'react'
+import React, {FC, lazy, Suspense, useContext, useCallback} from 'react'
 import {
   DraggableResizer,
   Orientation,
@@ -121,7 +121,7 @@ const ResultsPane: FC = () => {
     })
   }
 
-  const submit = () => {
+  const submit = useCallback(() => {
     setStatus(RemoteDataState.Loading)
     query(text, {
       vars: rangeToParam(range),
@@ -142,7 +142,7 @@ const ResultsPane: FC = () => {
         event('resultReceived', {status: 'error'})
         setStatus(RemoteDataState.Error)
       })
-  }
+  }, [text])
 
   const timeVars = [
     getRangeVariable(TIME_RANGE_START, range),

src/shared/components/FluxMonacoEditor.tsx

@@ -62,7 +62,7 @@ const FluxEditorMonaco: FC<Props> = ({
   variables,
 }) => {
   const connection = useRef<ConnectionManager>(null)
-  const {setEditor} = useContext(EditorContext)
+  const {editor, setEditor} = useContext(EditorContext)
   const isFluxQueryBuilder = useSelector(fluxQueryBuilder)
   const sessionStore = useContext(PersistanceContext)
   const {path} = useRouteMatch()
@@ -94,6 +94,17 @@ const FluxEditorMonaco: FC<Props> = ({
     sessionStore?.setSelection,
   ])
 
+  useEffect(() => {
+    if (!editor) {
+      return
+    }
+    submit(editor, () => {
+      if (onSubmitScript) {
+        onSubmitScript()
+      }
+    })
+  }, [editor, onSubmitScript])
+
   const editorDidMount = (editor: EditorType) => {
     connection.current = setupForReactMonacoEditor(editor)
     connection.current.updatePreludeModel(variables)
@@ -104,11 +115,6 @@ const FluxEditorMonaco: FC<Props> = ({
     }
 
     comments(editor)
-    submit(editor, () => {
-      if (onSubmitScript) {
-        onSubmitScript()
-      }
-    })
 
     if (autogrow) {
       registerAutogrow(editor)