fix(schemaComposition): remove editor styles when sync is disabled (#5699)

appletreeisyellow · web-flow · commit 69de5bc4e170 · 2022-09-09T13:38:31.000-05:00
* fix: remove highlight styles when sync is disabled

* chore: run prettier

* chore: add back to check compositionBlock
diff --git a/src/languageSupport/languages/flux/lsp/connection.ts b/src/languageSupport/languages/flux/lsp/connection.ts
@@ -248,7 +248,7 @@ class LspConnectionManager {
       },
     ]
 
-    const removeAllStyles = !compositionBlock && schema.composition.diverged
+    const removeAllStyles = !compositionBlock || schema.composition.diverged
 
     this._compositionStyle = this._editor.deltaDecorations(
       this._compositionStyle,
@@ -263,6 +263,8 @@ class LspConnectionManager {
 
     if (removeAllStyles) {
       clickableInvisibleDiv.style.display = 'none'
+    } else {
+      clickableInvisibleDiv.style.display = 'block'
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ class LspConnectionManager {`
`248`	`248`	`},`
`249`	`249`	`]`
`250`	`250`
`251`		`- const removeAllStyles = !compositionBlock && schema.composition.diverged`
	`251`	`+ const removeAllStyles = !compositionBlock \|\| schema.composition.diverged`
`252`	`252`
`253`	`253`	`this._compositionStyle = this._editor.deltaDecorations(`
`254`	`254`	`this._compositionStyle,`
`@@ -263,6 +263,8 @@ class LspConnectionManager {`
`263`	`263`
`264`	`264`	`if (removeAllStyles) {`
`265`	`265`	`clickableInvisibleDiv.style.display = 'none'`
	`266`	`+ } else {`
	`267`	`+ clickableInvisibleDiv.style.display = 'block'`
`266`	`268`	`}`
`267`	`269`	`}`
`268`	`270`