fix(sub): do not get subs twice (#6080)

Gene Hynson · web-flow · commit 6c76823b9816 · 2022-10-14T20:46:07.000Z
diff --git a/src/writeData/subscriptions/context/subscription.list.tsx b/src/writeData/subscriptions/context/subscription.list.tsx
@@ -124,13 +124,10 @@ export const SubscriptionListProvider: FC = ({children}) => {
     }
   }
   const change = useCallback(
-    async (id: string): Promise<void> => {
-      setLoading(RemoteDataState.Loading)
-      if (!subscriptions) {
-        await getAll()
+    (id: string) => {
+      if (subscriptions) {
+        setCurrentID(id)
       }
-      setCurrentID(id)
-      setLoading(RemoteDataState.Done)
     },
     [setCurrentID, subscriptions]
   )

Original file line number	Diff line number	Diff line change
`@@ -124,13 +124,10 @@ export const SubscriptionListProvider: FC = ({children}) => {`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`	`const change = useCallback(`
`127`		`- async (id: string): Promise<void> => {`
`128`		`- setLoading(RemoteDataState.Loading)`
`129`		`- if (!subscriptions) {`
`130`		`- await getAll()`
	`127`	`+ (id: string) => {`
	`128`	`+ if (subscriptions) {`
	`129`	`+ setCurrentID(id)`
`131`	`130`	`}`
`132`		`- setCurrentID(id)`
`133`		`- setLoading(RemoteDataState.Done)`
`134`	`131`	`},`
`135`	`132`	`[setCurrentID, subscriptions]`
`136`	`133`	`)`