fix: intercept the correct api calls and other minor fixes for pinned notebooks tests (#4272)

Author: TCL735

cypress/e2e/cloud/pinned.test.ts

@@ -211,9 +211,9 @@ from(bucket: "${name}"{rightarrow}
       cy.setFeatureFlags({
         pinnedItems: true,
       })
-      cy.intercept('GET', '**/notebooks').as('getNotebooks')
-      cy.getByTestID('nav-item-flows').should('be.visible')
-      cy.clickNavBarItem('nav-item-flows')
+      cy.intercept('GET', '/api/v2private/notebooks*').as('getNotebooks')
+      cy.intercept('PATCH', '/api/v2private/notebooks/*').as('updateNotebook')
+
       const now = Date.now()
       cy.writeData(
         [
@@ -224,21 +224,24 @@ from(bucket: "${name}"{rightarrow}
         ],
         'defbuck'
       )
+      cy.getByTestID('nav-item-flows').should('be.visible')
+      cy.clickNavBarItem('nav-item-flows')
+      cy.wait('@getNotebooks')
+
       cy.getByTestID('preset-new')
         .first()
         .click()
+      cy.wait('@getNotebooks')
+      cy.wait('@updateNotebook')
 
       cy.getByTestID('page-title')
         .first()
         .click()
-      cy.intercept('GET', '**/notebooks').as('getNotebooks')
-      cy.intercept('PATCH', '**/notebooks/*').as('updateNotebook')
       cy.getByTestID('renamable-page-title--input')
         .clear()
-        .type('Flow')
-        .type('{enter}')
-
+        .type('Flow{enter}')
       cy.wait('@updateNotebook')
+
       cy.getByTestID('time-machine-submit-button')
         .should('be.visible')
         .and('be.disabled')
@@ -253,7 +256,6 @@ from(bucket: "${name}"{rightarrow}
             .last()
             .click()
         })
-      cy.wait('@updateNotebook')
       cy.visit(`/orgs/${orgID}/notebooks`)
       cy.wait('@getNotebooks')
     })
@@ -263,6 +265,7 @@ from(bucket: "${name}"{rightarrow}
         cy.getByTestID('context-menu-flow').click()
       })
       cy.getByTestID('context-pin-flow').click()
+      cy.getByTestID('notification-success').should('be.visible')
 
       cy.visit('/')
       cy.getByTestID('tree-nav')
@@ -276,7 +279,11 @@ from(bucket: "${name}"{rightarrow}
         cy.getByTestID('context-menu-flow').click()
       })
       cy.getByTestID('context-pin-flow').click()
-      cy.getByTestID('notification-success--children').should('exist')
+      cy.getByTestID('notification-success').should('be.visible')
+      cy.getByTestID('notification-success--dismiss').click()
+
+      cy.intercept('PUT', '**/pinned/*').as('updatePinned')
+      const updatedName = 'Bucks in Six'
 
       cy.getByTestID('resource-editable-name')
         .first()
@@ -285,43 +292,35 @@ from(bucket: "${name}"{rightarrow}
       cy.getByTestID('flow-card--name-button')
         .first()
         .click()
-      cy.intercept('PUT', '**/pinned/*').as('updatePinned')
 
       cy.get('.cf-input-field')
         .last()
-        .focus()
-        .type('Bucks In Six')
-        .type('{enter}')
-      cy.getByTestID('notification-success--children').should('exist')
+        .type(`${updatedName}{enter}`)
+
+      cy.getByTestID('notification-success').should('be.visible')
       cy.wait('@updatePinned')
       cy.wait('@updateNotebook')
       cy.visit('/')
       cy.getByTestID('tree-nav')
       cy.getByTestID('pinneditems--container').within(() => {
-        cy.getByTestID('pinneditems--link').should(
-          'contain.text',
-          'Bucks In Six'
-        )
+        cy.getByTestID('pinneditems--link').should('contain.text', updatedName)
       })
     })
 
     it('unpins when the resource it is pointing to is deleted', () => {
-      cy.getByTestID('resource-editable-name')
-        .first()
-        .trigger('mouseover')
-
-      cy.getByTestID('flow-card--name-button')
-        .first()
-        .click()
-
       cy.getByTestID('flow-card--Flow').within(() => {
         cy.getByTestID('context-menu-flow').click()
       })
       cy.getByTestID('context-pin-flow').click()
+      cy.getByTestID('notification-success').should('be.visible')
+      cy.getByTestID('notification-success--dismiss').click()
+
       cy.getByTestID('flow-card--Flow').within(() => {
         cy.getByTestID(`context-delete-menu--button`).click()
       })
       cy.getByTestID(`context-delete-menu--confirm-button`).click()
+      cy.getByTestID('notification-success').should('be.visible')
+
       cy.visit('/')
       cy.getByTestID('tree-nav')
       cy.getByTestID('pinneditems--emptystate').should(