feat: feature flag usage of the fastFromFlux function (#4593)

Author: asalem1

package.json

@@ -165,7 +165,7 @@
     "@docsearch/react": "^3.0.0-alpha.37",
     "@influxdata/clockface": "^4.0.1",
     "@influxdata/flux-lsp-browser": "0.8.8",
-    "@influxdata/giraffe": "^2.25.0",
+    "@influxdata/giraffe": "^2.26.0",
     "@influxdata/influxdb-templates": "0.9.0",
     "@influxdata/react-custom-scrollbars": "4.3.8",
     "abortcontroller-polyfill": "^1.3.0",
@@ -221,8 +221,8 @@
     "s2-geometry": "^1.2.10",
     "use-local-storage-state": "^9.0.2",
     "worker-plugin": "^5.0.1",
-    "y-websocket": "^1.3.16",
-    "yjs": "^13.5.13"
+    "y-websocket": "^1.4.3",
+    "yjs": "^13.5.36"
   },
   "resolutions": {
     "mocha/**/minimist": "^0.0.8",

src/alerting/utils/activity.ts

@@ -1,7 +1,8 @@
 // Utils
 import {runQuery} from 'src/shared/apis/query'
-import {fromFlux} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux} from '@influxdata/giraffe'
 import {event} from 'src/cloud/utils/reporting'
+import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 
 // Constants
 import {MONITORING_BUCKET} from 'src/alerting/constants'
@@ -54,7 +55,9 @@ export const processResponse = ({
       return Promise.reject(new Error(resp.message))
     }
 
-    const {table} = fromFlux(resp.csv)
+    const {table} = isFlagEnabled('fastFromFlux')
+      ? fastFromFlux(resp.csv)
+      : fromFlux(resp.csv)
     const rows: Row[] = []
 
     for (let i = 0; i < table.length; i++) {

src/alerting/utils/history.test.ts

@@ -6,6 +6,7 @@ import {runQuery} from 'src/shared/apis/query'
 
 jest.mock('@influxdata/giraffe', () => ({
   fromFlux: jest.fn(),
+  fastFromFlux: jest.fn(),
   // todo: test will fails on binaryPrefixFormatter not a function in src/shared/copy/notifications.ts:22:24 this mock can be removed after this will be fixed
   binaryPrefixFormatter: jest.fn(),
 }))

src/alerting/utils/history.ts

@@ -1,11 +1,12 @@
 // Libraries
-import {fromFlux} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux} from '@influxdata/giraffe'
 
 // Utils
 import {runQuery, RunQueryResult} from 'src/shared/apis/query'
 import {parseSearchInput, searchExprToFlux} from 'src/eventViewer/utils/search'
 import {findNodes} from 'src/shared/utils/ast'
 import {event} from 'src/cloud/utils/reporting'
+import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 
 // Constants
 import {
@@ -149,7 +150,9 @@ export const processResponse = ({
       return Promise.reject(new Error(resp.message))
     }
 
-    const {table} = fromFlux(resp.csv)
+    const {table} = isFlagEnabled('fastFromFlux')
+      ? fastFromFlux(resp.csv)
+      : fromFlux(resp.csv)
     const rows: Row[] = []
 
     for (let i = 0; i < table.length; i++) {

src/alerting/utils/statusEvents.test.ts

@@ -5,6 +5,9 @@ import {mocked} from 'ts-jest/utils'
 
 jest.mock('@influxdata/giraffe', () => ({
   fromFlux: jest.fn(),
+  fastFromFlux: jest.fn(),
+  // todo: test will fails on binaryPrefixFormatter not a function in src/shared/copy/notifications.ts:22:24 this mock can be removed after this will be fixed
+  binaryPrefixFormatter: jest.fn(),
 }))
 // todo: test will fails on binaryPrefixFormatter not a function in src/shared/copy/notifications.ts:22:24 this mock can be removed after this will be fixed
 jest.mock('src/cloud/utils/reporting')

src/alerting/utils/statusEvents.ts

@@ -1,7 +1,8 @@
 // Utils
 import {runQuery} from 'src/shared/apis/query'
-import {fromFlux} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux} from '@influxdata/giraffe'
 import {event} from 'src/cloud/utils/reporting'
+import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 
 // Constants
 import {MONITORING_BUCKET} from 'src/alerting/constants'
@@ -50,7 +51,10 @@ export const processStatusesResponse = ({
       return Promise.reject(new Error(resp.message))
     }
 
-    const {table} = fromFlux(resp.csv)
+    const {table} = isFlagEnabled(resp.csv)
+      ? fastFromFlux(resp.csv)
+      : fromFlux(resp.csv)
+
     const rows: Row[][] = [[]]
 
     for (let i = 0; i < table.length; i++) {

src/cloud/components/onboarding/useGetUserStatus.ts

@@ -1,4 +1,4 @@
-import {fromFlux} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux} from '@influxdata/giraffe'
 import {event} from 'src/cloud/utils/reporting'
 import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 import {Table} from '@influxdata/giraffe'
@@ -92,7 +92,8 @@ export const queryUsage = async (orgID: string, range?: string) => {
     csvToParse = usageStatsCsv
   }
 
-  const {table} = fromFlux(csvToParse)
+  const parser = isFlagEnabled('fastFromFlux') ? fastFromFlux : fromFlux
+  const {table} = parser(csvToParse)
   return table
 }
 

src/flows/components/ReadOnly.tsx

@@ -2,7 +2,8 @@
 import React, {FC, useContext, useEffect} from 'react'
 import {AppWrapper, DapperScrollbars, Page} from '@influxdata/clockface'
 import {useParams} from 'react-router'
-import {fromFlux} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux} from '@influxdata/giraffe'
+import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 
 // Contexts
 import {FlowProvider} from 'src/flows/context/shared'
@@ -47,7 +48,9 @@ const RunPipeResults: FC = () => {
         .then(res =>
           res.text().then(resp => {
             if (res.status == 200) {
-              const csv = fromFlux(resp)
+              const csv = isFlagEnabled('fastFromFlux')
+                ? fastFromFlux(resp)
+                : fromFlux(resp)
               setResult(id, {parsed: csv, source: ''})
               setStatuses({[id]: RemoteDataState.Done})
             } else {

src/shared/components/FluxTablesTransform.tsx

@@ -3,7 +3,7 @@ import React, {Component, RefObject, CSSProperties} from 'react'
 import {isEqual} from 'lodash'
 import {connect, ConnectedProps} from 'react-redux'
 import {withRouter, RouteComponentProps} from 'react-router-dom'
-import {fromFlux, FromFluxResult} from '@influxdata/giraffe'
+import {fromFlux, fastFromFlux, FromFluxResult} from '@influxdata/giraffe'
 
 // API
 import {RunQueryResult, RunQuerySuccessResult} from 'src/shared/apis/query'
@@ -47,6 +47,7 @@ import {
   CancelBox,
 } from 'src/types'
 import {event} from 'src/cloud/utils/reporting'
+import {isFlagEnabled} from '../utils/featureFlag'
 
 interface QueriesState {
   files: string[] | null
@@ -299,7 +300,8 @@ class TimeSeries extends Component<Props, State> {
       }
 
       const files = (results as RunQuerySuccessResult[]).map(r => r.csv)
-      const giraffeResult = fromFlux(files.join('\n\n'))
+      const parser = isFlagEnabled('fastFromFlux') ? fastFromFlux : fromFlux
+      const giraffeResult = parser(files.join('\n\n'))
 
       this.pendingReload = false
       // this check prevents a memory leak https://github.com/influxdata/ui/issues/2137