Skip to content

Commit 8e501f3

Browse files
fix(firstMile): subway nav position fixed (no scroll with page) (#5684)
1 parent e0e46f7 commit 8e501f3

File tree

6 files changed

+20
-5
lines changed

6 files changed

+20
-5
lines changed

src/homepageExperience/components/HomepageExperience.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ h1#first-mile--header {
1414
width: 100%;
1515
}
1616

17+
.homepage-wizard-container--subway-inner {
18+
width: 100%;
19+
position: sticky;
20+
top: 0;
21+
}
22+
1723
.homepage-wizard-container--subway {
1824
display: flex;
1925
flex-direction: column;

src/homepageExperience/containers/ArduinoWizard.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,10 @@ export class ArduinoWizard extends PureComponent<{}, State> {
181181
<Page.Contents scrollable={true}>
182182
<div className="homepage-wizard-container">
183183
<aside className="homepage-wizard-container--subway">
184-
<div style={{width: '100%'}} data-testid="subway-nav">
184+
<div
185+
className="homepage-wizard-container--subway-inner"
186+
data-testid="subway-nav"
187+
>
185188
<SubwayNav
186189
currentStep={this.state.currentStep}
187190
onStepClick={this.handleNavClick}

src/homepageExperience/containers/CliWizard.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,10 @@ export class CliWizard extends PureComponent<{}, State> {
177177
<Page.Contents scrollable={true}>
178178
<div className="homepage-wizard-container">
179179
<aside className="homepage-wizard-container--subway">
180-
<div style={{width: '100%'}} data-testid="subway-nav">
180+
<div
181+
className="homepage-wizard-container--subway-inner"
182+
data-testid="subway-nav"
183+
>
181184
<SubwayNav
182185
currentStep={this.state.currentStep}
183186
onStepClick={this.handleNavClick}

src/homepageExperience/containers/GoWizard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ export class GoWizard extends PureComponent<null, State> {
180180
<Page.Contents scrollable={true}>
181181
<div className="homepage-wizard-container">
182182
<aside className="homepage-wizard-container--subway">
183-
<div style={{width: '100%'}}>
183+
<div className="homepage-wizard-container--subway-inner">
184184
<SubwayNav
185185
currentStep={this.state.currentStep}
186186
onStepClick={this.handleNavClick}

src/homepageExperience/containers/NodejsWizard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ export class NodejsWizard extends PureComponent<null, State> {
181181
<Page.Contents scrollable={true}>
182182
<div className="homepage-wizard-container">
183183
<aside className="homepage-wizard-container--subway">
184-
<div style={{width: '100%'}}>
184+
<div className="homepage-wizard-container--subway-inner">
185185
<SubwayNav
186186
currentStep={this.state.currentStep}
187187
onStepClick={this.handleNavClick}

src/homepageExperience/containers/PythonWizard.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,10 @@ export class PythonWizard extends PureComponent<null, State> {
183183
<Page.Contents scrollable={true}>
184184
<div className="homepage-wizard-container">
185185
<aside className="homepage-wizard-container--subway">
186-
<div style={{width: '100%'}} data-testid="subway-nav">
186+
<div
187+
className="homepage-wizard-container--subway-inner"
188+
data-testid="subway-nav"
189+
>
187190
<SubwayNav
188191
currentStep={this.state.currentStep}
189192
onStepClick={this.handleNavClick}

0 commit comments

Comments
 (0)