Skip to content

Commit a3f971e

Browse files
fix: notebooks single stat view stays in place when users configure (#3560)
1 parent fe11ddf commit a3f971e

File tree

3 files changed

+12
-22
lines changed

3 files changed

+12
-22
lines changed

src/flows/pipes/Notification/readOnly.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
ComponentSize,
1212
Panel,
1313
AlignItems,
14-
Dropdown,
14+
List,
1515
InfluxColors,
1616
TechnoSpinner,
1717
SpinnerContainer,
@@ -143,13 +143,13 @@ const ReadOnly: FC<PipeProp> = ({Context}) => {
143143
<Form.Element
144144
required={true}
145145
label="Endpoint"
146-
className="endpoint-dropdown--element"
146+
className="endpoint-list--element"
147147
>
148-
<Dropdown.Menu className="flows-endpoints--dropdown">
149-
<Dropdown.Item selected={true}>
148+
<List>
149+
<List.Item selected={true}>
150150
{ENDPOINT_DEFINITIONS[data.endpoint].name}
151-
</Dropdown.Item>
152-
</Dropdown.Menu>
151+
</List.Item>
152+
</List>
153153
</Form.Element>
154154
<FlexBox.Child grow={1} shrink={1}>
155155
<Form.Element

src/flows/pipes/Notification/styles.scss

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
.flows-endpoints--dropdown {
2-
background: #181820;
3-
height: 100%;
4-
}
5-
61
.slack-endpoint-details--flex {
72
display: flex;
83
flex-direction: column;
@@ -56,7 +51,7 @@
5651
padding: 8px;
5752
}
5853

59-
.endpoint-dropdown--element {
54+
.endpoint-list--element {
6055
flex: 1;
6156
max-width: 14%;
6257
}

src/flows/pipes/Notification/view.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
Panel,
2424
AlignItems,
2525
JustifyContent,
26-
Dropdown,
26+
List,
2727
ComponentColor,
2828
Button,
2929
InfluxColors,
@@ -247,15 +247,15 @@ const Notification: FC<PipeProp> = ({Context}) => {
247247
)
248248
.sort((a, b) => ENDPOINT_ORDER.indexOf(a) - ENDPOINT_ORDER.indexOf(b))
249249
.map(k => (
250-
<Dropdown.Item
250+
<List.Item
251251
key={k}
252252
id={k}
253253
testID={`dropdown-item--${k}`}
254254
onClick={() => updateEndpoint(k)}
255255
selected={data.endpoint === k}
256256
>
257257
{ENDPOINT_DEFINITIONS[k].name}
258-
</Dropdown.Item>
258+
</List.Item>
259259
))
260260

261261
const generateDeadmanTask = useCallback(() => {
@@ -646,14 +646,9 @@ ${ENDPOINT_DEFINITIONS[data.endpoint]?.generateTestQuery(data.endpointData)}`
646646
<Form.Element
647647
required={true}
648648
label="Endpoint"
649-
className="endpoint-dropdown--element"
649+
className="endpoint-list--element"
650650
>
651-
<Dropdown.Menu
652-
className="flows-endpoints--dropdown"
653-
maxHeight={500}
654-
>
655-
{avail}
656-
</Dropdown.Menu>
651+
<List>{avail}</List>
657652
</Form.Element>
658653
<FlexBox.Child grow={1} shrink={1}>
659654
<Form.Element

0 commit comments

Comments
 (0)