fix: remove hard-coded error message for Aggregate Type error (#3932)

Author: ChitlangeSahas

src/shared/components/notifications/NotificationButtons.tsx

@@ -1,11 +1,6 @@
 // Libraries
-import React, {FC} from 'react'
+import React from 'react'
 import {Link} from 'react-router-dom'
-import {Button, ComponentSize} from '@influxdata/clockface'
-import {useDispatch} from 'react-redux'
-
-// Utils
-import {setFunctions} from 'src/timeMachine/actions/queryBuilder'
 
 // Types
 import {NotificationDismiss} from 'src/types'
@@ -20,31 +15,3 @@ export const getDeleteAccountWarningButton = (
     </Link>
   )
 }
-
-interface AggregateTypeErrorButtonProps {
-  onDismiss: NotificationDismiss
-}
-
-export const AggregateTypeErrorButton: FC<AggregateTypeErrorButtonProps> = ({
-  onDismiss,
-}) => {
-  const dispatch = useDispatch()
-  const onClick = () => {
-    dispatch(setFunctions(['last']))
-    onDismiss()
-  }
-
-  return (
-    <Button
-      text="Update Aggregate Type"
-      onClick={onClick}
-      size={ComponentSize.ExtraSmall}
-    />
-  )
-}
-
-export const getAggregateTypeErrorButton = (
-  onDismiss: NotificationDismiss
-): JSX.Element => {
-  return <AggregateTypeErrorButton onDismiss={onDismiss} />
-}

src/timeMachine/actions/queries.ts

@@ -15,22 +15,16 @@ import {notify} from 'src/shared/actions/notifications'
 import {hydrateVariables} from 'src/variables/actions/thunks'
 
 // Constants
-import {
-  rateLimitReached,
-  resultTooLarge,
-  updateAggregateType,
-} from 'src/shared/copy/notifications'
+import {rateLimitReached, resultTooLarge} from 'src/shared/copy/notifications'
 
 // Utils
 import fromFlux from 'src/shared/utils/fromFlux'
 import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 import {buildUsedVarsOption} from 'src/variables/utils/buildVarsOption'
 import {findNodes} from 'src/shared/utils/ast'
-import {isAggregateTypeError} from 'src/utils/aggregateTypeErrors'
 import {event} from 'src/cloud/utils/reporting'
 import {asSimplyKeyValueVariables, hashCode} from 'src/shared/apis/queryCache'
 import {filterUnusedVarsBasedOnQuery} from 'src/shared/utils/filterUnusedVars'
-import {getAggregateTypeErrorButton} from 'src/shared/components/notifications/NotificationButtons'
 
 // Types
 import {CancelBox} from 'src/types/promises'
@@ -44,7 +38,6 @@ import {
   QueryEditMode,
   BuilderTagsType,
   Variable,
-  NotificationButtonElement,
 } from 'src/types'
 
 // Selectors
@@ -333,16 +326,6 @@ export const executeQueries = (abortController?: AbortController) => async (
 
     for (const result of results) {
       if (result.type === 'UNKNOWN_ERROR') {
-        if (
-          isAggregateTypeError(result.code, result.message) &&
-          state.currentExplorer.isAutoFunction
-        ) {
-          const message = `It looks like you're trying to apply a number-based aggregate function to a string, which cannot be processed. You can fix this by selecting the Aggregate Function "Last"`
-          const buttonElement: NotificationButtonElement = onDismiss =>
-            getAggregateTypeErrorButton(onDismiss)
-          dispatch(notify(updateAggregateType(message, buttonElement)))
-        }
-
         throw new Error(result.message)
       }