Skip to content

Commit bebf194

Browse files
feat: update bucket in bucket selector after Create Bucket button is used (#4653)
1 parent 2c87c95 commit bebf194

File tree

4 files changed

+19
-4
lines changed

4 files changed

+19
-4
lines changed

src/buckets/components/CreateBucketButton.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {showOverlay, dismissOverlay} from 'src/overlays/actions/overlays'
1414
import {getBucketLimitStatus} from 'src/cloud/utils/limits'
1515

1616
// Types
17-
import {AppState} from 'src/types'
17+
import {AppState, OwnBucket} from 'src/types'
1818

1919
// Constants
2020
import {CLOUD} from 'src/shared/constants'
@@ -24,6 +24,7 @@ type ReduxProps = ConnectedProps<typeof connector>
2424

2525
type CreateButtonProps = {
2626
useSimplifiedBucketForm?: boolean
27+
callbackAfterBucketCreation?: (bucket: OwnBucket) => void
2728
}
2829

2930
type Props = ReduxProps & CreateButtonProps
@@ -33,6 +34,7 @@ const CreateBucketButton: FC<Props> = ({
3334
onShowOverlay,
3435
onDismissOverlay,
3536
useSimplifiedBucketForm = false,
37+
callbackAfterBucketCreation = () => {},
3638
}) => {
3739
const dispatch = useDispatch()
3840
useEffect(() => {
@@ -41,7 +43,10 @@ const CreateBucketButton: FC<Props> = ({
4143
}, [dispatch])
4244

4345
const overlayParams = useSimplifiedBucketForm
44-
? {useSimplifiedBucketForm: true}
46+
? {
47+
useSimplifiedBucketForm: true,
48+
callbackAfterBucketCreation,
49+
}
4550
: null
4651
const handleItemClick = (): void => {
4752
event('create bucket clicked')

src/buckets/components/createBucketForm/CreateBucketForm.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
initialBucketState,
1919
DEFAULT_RULES,
2020
} from 'src/buckets/reducers/createBucket'
21-
import {AppState, Bucket, RetentionRule} from 'src/types'
21+
import {AppState, Bucket, OwnBucket, RetentionRule} from 'src/types'
2222
import {event} from 'src/cloud/utils/reporting'
2323

2424
// Selectors
@@ -40,6 +40,7 @@ interface CreateBucketFormProps {
4040
onClose: () => void
4141
testID?: string
4242
useSimplifiedBucketForm?: boolean
43+
callbackAfterBucketCreation?: (bucket: OwnBucket) => void
4344
}
4445

4546
export const CreateBucketForm: FC<CreateBucketFormProps> = props => {
@@ -145,6 +146,10 @@ export const CreateBucketForm: FC<CreateBucketFormProps> = props => {
145146
if (overlayParams?.onUpdateBucket) {
146147
overlayParams.onUpdateBucket(bucket)
147148
}
149+
150+
if (props.callbackAfterBucketCreation) {
151+
props.callbackAfterBucketCreation(bucket)
152+
}
148153
}
149154

150155
const handleChangeInput = (event: ChangeEvent<HTMLInputElement>): void => {

src/buckets/components/createBucketForm/CreateBucketOverlay.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ import {getBucketOverlayWidth} from 'src/buckets/constants'
1414
const CreateBucketOverlay: FC = () => {
1515
const {onClose, params} = useContext(OverlayContext)
1616
const useSimplifiedBucketForm = params?.useSimplifiedBucketForm
17+
const callbackAfterBucketCreation = params?.callbackAfterBucketCreation
1718

1819
return (
1920
<Overlay.Container maxWidth={getBucketOverlayWidth()}>
2021
<Overlay.Header title="Create Bucket" onDismiss={onClose} />
2122
<CreateBucketForm
2223
onClose={onClose}
2324
useSimplifiedBucketForm={useSimplifiedBucketForm}
25+
callbackAfterBucketCreation={callbackAfterBucketCreation}
2426
/>
2527
</Overlay.Container>
2628
)

src/writeData/components/WriteDataHelperBuckets.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ const WriteDataHelperBuckets: FC<Props> = ({
9191
<>
9292
<Heading element={HeadingElement.H6} className={className}>
9393
Bucket
94-
<CreateBucketButton useSimplifiedBucketForm={useSimplifiedBucketForm} />
94+
<CreateBucketButton
95+
useSimplifiedBucketForm={useSimplifiedBucketForm}
96+
callbackAfterBucketCreation={changeBucket}
97+
/>
9598
</Heading>
9699
{body}
97100
</>

0 commit comments

Comments
 (0)