feat: inject pipe-forward operator only when necessary (#4546)

* feat: only add |> sign for fluxtypes with <-

* fix: prettier

* fix: target <- with String.startsWith()

* fix: prettier

* test: remove pipe-forward operator

Author: blegesse-w

cypress/e2e/cloud/explorer.test.ts

@@ -60,7 +60,7 @@ describe('DataExplorer', () => {
         cy.getByTestID('flux--microsecond--inject').click()
 
         getTimeMachineText().then(text => {
-          const expected = 'import "date" |> date.microsecond(t: )'
+          const expected = 'import "date"  date.microsecond(t: )'
           cy.fluxEqual(text, expected).should('be.true')
         })
       })

src/flows/pipes/RawFluxEditor/view.tsx

@@ -76,10 +76,17 @@ const Query: FC<PipeProp> = ({Context}) => {
   const injectIntoEditor = useCallback(
     (fn): void => {
       let text = ''
-      if (fn.name === 'from' || fn.name === 'union') {
-        text = `${fn.example}`
+      if (CLOUD && isFlagEnabled('fluxDynamicDocs')) {
+        // only fluxTypes with <- sign require a pipe forward sign
+        text = fn.fluxType.startsWith('<-', 1)
+          ? `  |> ${fn.example}`
+          : `${fn.example}`
       } else {
-        text = `  |> ${fn.example}`
+        if (fn.name === 'from' || fn.name === 'union') {
+          text = `${fn.example}`
+        } else {
+          text = `  |> ${fn.example}`
+        }
       }
 
       const getHeader = fn => {
@@ -88,7 +95,11 @@ const Query: FC<PipeProp> = ({Context}) => {
         // universe packages are loaded by deafult. Don't need import statement
         if (fn.package && fn.package !== 'universe') {
           importStatement = `import "${fn.package}"`
-          if (isFlagEnabled('fluxDynamicDocs') && fn.path.includes('/')) {
+          if (
+            CLOUD &&
+            isFlagEnabled('fluxDynamicDocs') &&
+            fn.path.includes('/')
+          ) {
             importStatement = `import "${fn.path}"`
           }
         }

src/timeMachine/components/TimeMachineFluxEditor.tsx

@@ -104,9 +104,22 @@ const TimeMachineFluxEditor: FC = () => {
 
     let text = ''
     if (shouldInsertOnNextLine) {
-      text = `\n  |> ${func.example}`
+      if (CLOUD && isFlagEnabled('fluxDynamicDocs')) {
+        // only fluxTypes with <- sign require a pipe forward sign
+        text = func.fluxType.startsWith('<-', 1)
+          ? `\n  |> ${func.example}`
+          : `\n   ${func.example}`
+      } else {
+        text = `\n  |> ${func.example}`
+      }
     } else {
-      text = `  |> ${func.example}\n`
+      if (CLOUD && isFlagEnabled('fluxDynamicDocs')) {
+        text = func.fluxType.startsWith('<-', 1)
+          ? `  |> ${func.example}\n`
+          : `   ${func.example}\n`
+      } else {
+        text = `  |> ${func.example}\n`
+      }
     }
 
     if (functionRequiresNewLine(func.name)) {