Skip to content

Commit d38d2c9

Browse files
drdelambredrdelambre
authored
fix: remove delays (#3348)
1 parent c1865d4 commit d38d2c9

File tree

5 files changed

+57
-65
lines changed

5 files changed

+57
-65
lines changed

‎cypress/e2e/shared/dashboardsRefresh.test.ts‎

Lines changed: 46 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ describe('Dashboard refresh', () => {
5656
cy.get('.monaco-editor .view-line:last')
5757
.click({force: true})
5858
.focused()
59-
.type(query1, {force: true, delay: 1})
59+
.type(query1, {force: true})
6060
})
6161
cy.getByTestID('overlay').within(() => {
6262
cy.getByTestID('page-title').click()
6363
cy.getByTestID('renamable-page-title--input')
6464
.clear()
65-
.type('blah{enter}', {force: true, delay: 1})
65+
.type('blah{enter}', {force: true})
6666
cy.getByTestID('save-cell--button').click()
6767
})
6868
})
@@ -74,7 +74,7 @@ describe('Dashboard refresh', () => {
7474
cy.getByTestID('enable-auto-refresh-button').click()
7575
cy.getByTestID('auto-refresh-input')
7676
.clear()
77-
.type('2s', {force: true, delay: 1})
77+
.type('2s', {force: true})
7878
cy.getByTestID('refresh-form-activate-button').click({force: true})
7979
cy.wait('@refreshQuery')
8080
cy.getByTestID('enable-auto-refresh-button').click()
@@ -92,13 +92,13 @@ describe('Dashboard refresh', () => {
9292
cy.getByTestID('enable-auto-refresh-button').click()
9393
cy.getByTestID('auto-refresh-input')
9494
.clear()
95-
.type('4s', {force: true, delay: 1})
96-
.type('{enter}', {force: true, delay: 1})
95+
.type('4s', {force: true})
96+
.type('{enter}', {force: true})
9797
cy.getByTestID('timerange-popover-button').click()
9898
cy.getByTestID('timerange-popover--dialog').within(() => {
9999
cy.getByTestID('timerange--input')
100100
.clear()
101-
.type(`${jumpAheadTime('00:00:05')}`, {force: true, delay: 1})
101+
.type(`${jumpAheadTime('00:00:05')}`, {force: true})
102102
cy.getByTestID('daterange--apply-btn').click()
103103
})
104104
cy.getByTestID('refresh-form-activate-button').click()
@@ -121,13 +121,13 @@ describe('Dashboard refresh', () => {
121121
cy.getByTestID('enable-auto-refresh-button').click()
122122
cy.getByTestID('auto-refresh-input')
123123
.clear()
124-
.type('2s', {force: true, delay: 1})
125-
.type('{enter}', {force: true, delay: 1})
124+
.type('2s', {force: true})
125+
.type('{enter}', {force: true})
126126
cy.getByTestID('timerange-popover-button').click()
127127
cy.getByTestID('timerange-popover--dialog').within(() => {
128128
cy.getByTestID('timerange--input')
129129
.clear()
130-
.type(`${jumpAheadTime('00:00:10')}`, {force: true, delay: 1})
130+
.type(`${jumpAheadTime('00:00:10')}`, {force: true})
131131
cy.getByTestID('daterange--apply-btn').click()
132132
})
133133
cy.intercept('POST', '/api/v2/query?*', req => {
@@ -170,13 +170,13 @@ describe('Dashboard refresh', () => {
170170
cy.getByTestID('enable-auto-refresh-button').click()
171171
cy.getByTestID('auto-refresh-input')
172172
.clear()
173-
.type('3s', {force: true, delay: 1})
174-
.type('{enter}', {force: true, delay: 1})
173+
.type('3s', {force: true})
174+
.type('{enter}', {force: true})
175175
cy.getByTestID('timerange-popover-button').click()
176176
cy.getByTestID('timerange-popover--dialog').within(() => {
177177
cy.getByTestID('timerange--input')
178178
.clear()
179-
.type(`${jumpAheadTime('00:00:08')}`, {force: true, delay: 1})
179+
.type(`${jumpAheadTime('00:00:08')}`, {force: true})
180180
cy.getByTestID('daterange--apply-btn').click()
181181
})
182182
cy.intercept('POST', '/api/v2/query?*', req => {
@@ -259,14 +259,14 @@ describe('Dashboard refresh', () => {
259259
cy.get('.monaco-editor .view-line:last')
260260
.click({force: true})
261261
.focused()
262-
.type(query1, {force: true, delay: 1})
262+
.type(query1, {force: true})
263263
})
264264

265265
cy.getByTestID('overlay').within(() => {
266266
cy.getByTestID('page-title').click()
267267
cy.getByTestID('renamable-page-title--input')
268268
.clear()
269-
.type('blah{enter}', {force: true, delay: 1})
269+
.type('blah{enter}', {force: true})
270270
cy.getByTestID('save-cell--button').click()
271271
})
272272

@@ -280,7 +280,7 @@ describe('Dashboard refresh', () => {
280280
cy.get('.monaco-editor .view-line:last')
281281
.click({force: true})
282282
.focused()
283-
.type(query2, {force: true, delay: 1})
283+
.type(query2, {force: true})
284284
})
285285
cy.getByTestID('save-cell--button').click()
286286
})
@@ -305,7 +305,7 @@ describe('Dashboard refresh', () => {
305305
cy.getByTestID('enable-auto-refresh-button').click()
306306
cy.getByTestID('auto-refresh-input')
307307
.clear()
308-
.type('2s', {force: true, delay: 1})
308+
.type('2s', {force: true})
309309
cy.getByTestID('refresh-form-activate-button').click({force: true})
310310
cy.wait('@secondCellQuery')
311311
cy.wait('@firstCellQuery')
@@ -361,14 +361,14 @@ describe('Dashboard refresh', () => {
361361
.click({force: true})
362362
.focused()
363363
.clear()
364-
.type(query1, {force: true, delay: 1})
364+
.type(query1, {force: true})
365365
})
366366

367367
cy.getByTestID('overlay').within(() => {
368368
cy.getByTestID('page-title').click()
369369
cy.getByTestID('renamable-page-title--input')
370370
.clear()
371-
.type('blah{enter}', {force: true, delay: 1})
371+
.type('blah{enter}', {force: true})
372372
cy.getByTestID('save-cell--button').click()
373373
})
374374

@@ -382,7 +382,7 @@ describe('Dashboard refresh', () => {
382382
cy.get('.monaco-editor .view-line:last')
383383
.click({force: true})
384384
.focused()
385-
.type(query2, {force: true, delay: 1})
385+
.type(query2, {force: true})
386386
})
387387
cy.getByTestID('save-cell--button').click()
388388
})
@@ -406,7 +406,7 @@ describe('Dashboard refresh', () => {
406406
cy.getByTestID('enable-auto-refresh-button').click()
407407
cy.getByTestID('auto-refresh-input')
408408
.clear()
409-
.type('2s', {force: true, delay: 1})
409+
.type('2s', {force: true})
410410
cy.getByTestID('refresh-form-activate-button').click({force: true})
411411

412412
cy.wait('@secondCellQuery')
@@ -457,20 +457,18 @@ describe('Dashboard refresh', () => {
457457
|> range(start: v.timeRangeStart, stop: v.timeRangeStop)
458458
|> filter(fn: (r) => r["container_name"] == "beans")`
459459

460-
cy.getByTestID('flux-editor')
461-
.should('be.visible')
462-
.within(() => {
463-
cy.get('.monaco-editor .view-line:last')
464-
.click({force: true})
465-
.focused()
466-
.type(query1, {force: true, delay: 1})
467-
})
460+
cy.getByTestID('flux-editor').within(() => {
461+
cy.get('.monaco-editor .view-line:last')
462+
.click({force: true})
463+
.focused()
464+
.type(query1, {force: true})
465+
})
468466

469467
cy.getByTestID('overlay').within(() => {
470468
cy.getByTestID('page-title').click()
471469
cy.getByTestID('renamable-page-title--input')
472470
.clear()
473-
.type('blah{enter}', {force: true, delay: 1})
471+
.type('blah{enter}', {force: true})
474472
cy.getByTestID('save-cell--button').click()
475473
})
476474

@@ -480,14 +478,12 @@ describe('Dashboard refresh', () => {
480478
cy.getByTestID('toolbar-tab').click()
481479

482480
cy.getByTestID('overlay').within(() => {
483-
cy.getByTestID('flux-editor')
484-
.should('be.visible')
485-
.within(() => {
486-
cy.get('.monaco-editor .view-line:last')
487-
.click({force: true})
488-
.focused()
489-
.type(query2, {force: true, delay: 1})
490-
})
481+
cy.getByTestID('flux-editor').within(() => {
482+
cy.get('.monaco-editor .view-line:last')
483+
.click({force: true})
484+
.focused()
485+
.type(query2, {force: true})
486+
})
491487
cy.getByTestID('save-cell--button').click()
492488
})
493489

@@ -549,20 +545,18 @@ describe('Dashboard refresh', () => {
549545
|> range(start: v.timeRangeStart, stop: v.timeRangeStop)
550546
|> filter(fn: (r) => r["container_name"] == "beans")`
551547

552-
cy.getByTestID('flux-editor')
553-
.should('be.visible')
554-
.within(() => {
555-
cy.get('.monaco-editor .view-line:last')
556-
.click({force: true})
557-
.focused()
558-
.type(query1, {force: true, delay: 0})
559-
})
548+
cy.getByTestID('flux-editor').within(() => {
549+
cy.get('.monaco-editor .view-line:last')
550+
.click({force: true})
551+
.focused()
552+
.type(query1, {force: true})
553+
})
560554

561555
cy.getByTestID('overlay').within(() => {
562556
cy.getByTestID('page-title').click()
563557
cy.getByTestID('renamable-page-title--input')
564558
.clear()
565-
.type('blah{enter}', {force: true, delay: 1})
559+
.type('blah{enter}', {force: true})
566560
cy.getByTestID('save-cell--button').click()
567561
})
568562

@@ -572,14 +566,12 @@ describe('Dashboard refresh', () => {
572566
cy.getByTestID('toolbar-tab').click()
573567

574568
cy.getByTestID('overlay').within(() => {
575-
cy.getByTestID('flux-editor')
576-
.should('be.visible')
577-
.within(() => {
578-
cy.get('.monaco-editor .view-line:last')
579-
.click({force: true})
580-
.focused()
581-
.type(query2, {force: true, delay: 1})
582-
})
569+
cy.getByTestID('flux-editor').within(() => {
570+
cy.get('.monaco-editor .view-line:last')
571+
.click({force: true})
572+
.focused()
573+
.type(query2, {force: true})
574+
})
583575
cy.getByTestID('save-cell--button').click()
584576
})
585577

‎cypress/e2e/shared/dashboardsView.test.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ describe('Dashboard', () => {
108108
cy.get('.monaco-editor .view-line:last')
109109
.click({force: true})
110110
.focused()
111-
.type(`${headerPrefix} ${noteText}`, {force: true, delay: 1})
111+
.type(`${headerPrefix} ${noteText}`, {force: true})
112112

113113
cy.getByTestID('note-editor--preview').contains(noteText)
114114
cy.getByTestID('note-editor--preview').should('not.contain', headerPrefix)
@@ -173,7 +173,7 @@ describe('Dashboard', () => {
173173
cy.get('.monaco-editor .view-line:last')
174174
.click({force: true})
175175
.focused()
176-
.type(`${headerPrefix2} ${noteText2}`, {force: true, delay: 1})
176+
.type(`${headerPrefix2} ${noteText2}`, {force: true})
177177
cy.getByTestID('note-editor--preview').contains(noteText2)
178178
cy.getByTestID('note-editor--preview').should(
179179
'not.contain',
@@ -342,7 +342,7 @@ describe('Dashboard', () => {
342342
cy.get('.monaco-editor .view-line:last')
343343
.click({force: true})
344344
.focused()
345-
.type(' ', {force: true, delay: 1})
345+
.type(' ', {force: true})
346346
})
347347
cy.getByTestID('save-cell--button').click()
348348

@@ -601,7 +601,7 @@ describe('Dashboard', () => {
601601
|> filter(fn: (r) => r["tk1"] == "tv1")
602602
|> aggregateWindow(every: v.windowPeriod, fn: max)
603603
|> yield(name: "max")`,
604-
{force: true, delay: 1}
604+
{force: true}
605605
)
606606
})
607607

@@ -683,7 +683,7 @@ csv.from(csv: data) |> filter(fn: (r) => r.bucket == v.bucketsCSV)`
683683
|> filter(fn: (r) => r["_field"] == v.greeting)
684684
|> aggregateWindow(every: v.windowPeriod, fn: max)
685685
|> yield(name: "max")`,
686-
{force: true, delay: 1}
686+
{force: true}
687687
)
688688
})
689689
cy.get('.flux-toolbar--list-item')
@@ -902,7 +902,7 @@ csv.from(csv: data) |> filter(fn: (r) => r.bucket == v.bucketsCSV)`
902902
|> filter(fn: (r) => r["_measurement"] == "test")
903903
|> filter(fn: (r) => r["_field"] == "dopeness")
904904
|> filter(fn: (r) => r["container_name"] == v.build)`,
905-
{force: true, delay: 1}
905+
{force: true}
906906
)
907907
})
908908

@@ -1072,7 +1072,7 @@ csv.from(csv: data) |> filter(fn: (r) => r.bucket == v.bucketsCSV)`
10721072
|> filter(fn: (r) => r["_measurement"] == "test")
10731073
|> filter(fn: (r) => r["_field"] == "dopeness")
10741074
|> filter(fn: (r) => r["container_name"] == v.dependent)`,
1075-
{force: true, delay: 1}
1075+
{force: true}
10761076
)
10771077
})
10781078
cy.getByTestID('save-cell--button').click()
@@ -1300,7 +1300,7 @@ csv.from(csv: data) |> filter(fn: (r) => r.bucket == v.bucketsCSV)`
13001300
.click({force: true})
13011301
.focused()
13021302
.clear({force: true})
1303-
.type(query1, {force: true, delay: 1})
1303+
.type(query1, {force: true})
13041304
})
13051305
cy.getByTestID('overlay').within(() => {
13061306
cy.getByTestID('page-title').click()

‎cypress/e2e/shared/explorerVisualizations.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('visualizations', () => {
4646
.click({force: true})
4747
.focused()
4848
.clear()
49-
.type('from(', {force: true, delay: 2})
49+
.type('from(', {force: true})
5050
cy.getByTestID('time-machine-submit-button').click()
5151
})
5252
})

‎cypress/e2e/shared/tasks.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,7 @@ const createTask = (
707707
cy.get('textarea.inputarea')
708708
.click({force: true})
709709
.focused()
710-
.type(task, {force: true, delay: 2})
710+
.type(task, {force: true})
711711
})
712712

713713
cy.getByTestIDAndSetInputValue('task-form-name', name)

‎cypress/support/commands.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ export const createTaskFromEmpty = (
990990
cy.get('.monaco-editor .view-line:last')
991991
.click({force: true})
992992
.focused()
993-
.type(flux(bucket), {force: true, delay: 2})
993+
.type(flux(bucket), {force: true})
994994
})
995995
})
996996

0 commit comments

Comments
 (0)