fix: use honeybadger over toast for identity error reporting (#5068)

Author: wdoconnell

src/identity/actions/thunks/index.ts

@@ -6,12 +6,6 @@ import {
   setQuartzIdentity,
   setQuartzIdentityStatus,
 } from 'src/identity/actions/creators'
-import {notify} from 'src/shared/actions/notifications'
-import {
-  updateBillingFailed,
-  updateIdentityFailed,
-  updateOrgFailed,
-} from 'src/shared/copy/notifications'
 
 // Types
 import {RemoteDataState, GetState, NotificationAction} from 'src/types'
@@ -33,7 +27,13 @@ import {isFlagEnabled} from 'src/shared/utils/featureFlag'
 // Thunks
 import {getQuartzMeThunk} from 'src/me/actions/thunks'
 
-export const getQuartzIdentityThunk = () => async dispatch => {
+// Error Reporting
+import {reportErrorThroughHoneyBadger} from 'src/shared/utils/errors'
+
+export const getQuartzIdentityThunk = () => async (
+  dispatch: Dispatch<any>,
+  getState: GetState
+) => {
   if (!isFlagEnabled('quartzIdentity')) {
     dispatch(getQuartzMeThunk())
     return
@@ -50,10 +50,14 @@ export const getQuartzIdentityThunk = () => async dispatch => {
     const legacyMe = convertIdentityToMe(quartzIdentity)
     dispatch(setQuartzMe(legacyMe, RemoteDataState.Done))
     dispatch(setQuartzMeStatus(RemoteDataState.Done))
-  } catch (error) {
+  } catch (err) {
     dispatch(setQuartzIdentityStatus(RemoteDataState.Error))
     dispatch(setQuartzMeStatus(RemoteDataState.Error))
-    dispatch(notify(updateIdentityFailed()))
+
+    reportErrorThroughHoneyBadger(err, {
+      name: 'Failed to fetch /quartz/identity',
+      context: {state: getState()},
+    })
   }
 }
 
@@ -75,10 +79,14 @@ export const getBillingProviderThunk = () => async (
     const legacyMe = convertIdentityToMe(updatedState.identity.currentIdentity)
     dispatch(setQuartzMe(legacyMe, RemoteDataState.Done))
     dispatch(setQuartzMeStatus(RemoteDataState.Done))
-  } catch (error) {
+  } catch (err) {
     dispatch(setQuartzIdentityStatus(RemoteDataState.Error))
     dispatch(setQuartzMeStatus(RemoteDataState.Error))
-    dispatch(notify(updateBillingFailed()))
+
+    reportErrorThroughHoneyBadger(err, {
+      name: 'Failed to fetch /quartz/accounts/',
+      context: {state: getState()},
+    })
   }
 }
 
@@ -101,9 +109,13 @@ export const getCurrentOrgDetailsThunk = () => async (
     const legacyMe = convertIdentityToMe(updatedState.identity.currentIdentity)
     dispatch(setQuartzMe(legacyMe, RemoteDataState.Done))
     dispatch(setQuartzMeStatus(RemoteDataState.Done))
-  } catch (error) {
+  } catch (err) {
     dispatch(setQuartzIdentityStatus(RemoteDataState.Error))
     dispatch(setQuartzMeStatus(RemoteDataState.Error))
-    dispatch(notify(updateOrgFailed()))
+
+    reportErrorThroughHoneyBadger(err, {
+      name: 'Failed to fetch /quartz/orgs/:orgId',
+      context: {state: getState()},
+    })
   }
 }

src/identity/quartzOrganizations/actions/thunks/index.ts

@@ -13,35 +13,39 @@ import {
 import {PublishNotificationAction} from 'src/shared/actions/notifications'
 
 // Types
-import {RemoteDataState} from 'src/types'
+import {GetState, RemoteDataState} from 'src/types'
 import {OrganizationSummaries} from 'src/client/unityRoutes'
 
 type Actions = QuartzOrganizationActions | PublishNotificationAction
 type DefaultOrg = OrganizationSummaries[number]
 
-// Notifications
-import {notify} from 'src/shared/actions/notifications'
-import {updateQuartzOrganizationsFailed} from 'src/shared/copy/notifications'
+// Error Reporting
+import {reportErrorThroughHoneyBadger} from 'src/shared/utils/errors'
 
 export const getQuartzOrganizationsThunk = () => async (
-  dispatch: Dispatch<Actions>
+  dispatch: Dispatch<Actions>,
+  getState: GetState
 ) => {
   try {
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Loading))
     const quartzOrganizations = await fetchQuartzOrgs()
 
     dispatch(setQuartzOrganizations(quartzOrganizations))
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Done))
-  } catch (error) {
+  } catch (err) {
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Error))
-    dispatch(notify(updateQuartzOrganizationsFailed()))
+
+    reportErrorThroughHoneyBadger(err, {
+      name: 'Failed to fetch /quartz/orgs/',
+      context: {state: getState()},
+    })
   }
 }
 
 export const updateDefaultOrgThunk = (
   oldDefaultOrg: DefaultOrg,
   newDefaultOrg: DefaultOrg
-) => async (dispatch: Dispatch<Actions>) => {
+) => async (dispatch: Dispatch<Actions>, getState: GetState) => {
   try {
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Loading))
 
@@ -52,6 +56,10 @@ export const updateDefaultOrgThunk = (
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Done))
   } catch (err) {
     dispatch(setQuartzOrganizationsStatus(RemoteDataState.Error))
-    throw Error(err)
+
+    reportErrorThroughHoneyBadger(err, {
+      name: 'Failed to update /quartz/orgs/default',
+      context: {state: getState()},
+    })
   }
 }

src/shared/copy/notifications/categories/accounts-users-orgs.ts

@@ -130,26 +130,3 @@ export const removeUserSuccessful = (): Notification => ({
   ...defaultSuccessNotification,
   message: `User Removed`,
 })
-
-export const updateBillingFailed = (): Notification => ({
-  ...defaultErrorNotification,
-  message:
-    'Error retrieving account billing provider. Please refresh this page.',
-})
-
-export const updateIdentityFailed = (): Notification => ({
-  ...defaultErrorNotification,
-  message: 'Error retrieving user identity. Please refresh this page.',
-})
-
-export const updateOrgFailed = (): Notification => ({
-  ...defaultErrorNotification,
-  message:
-    'Error retrieving new organization information. Please refresh this page.',
-})
-
-export const updateQuartzOrganizationsFailed = (): Notification => ({
-  ...defaultErrorNotification,
-  message:
-    'We were unable to retrieve the list of your InfluxData organizations. Please refresh this page.',
-})