fix(TasksPage): remove showInactive setState from constructor (#4977)

Author: blegesse-w

src/tasks/actions/thunks.ts

@@ -125,7 +125,7 @@ export const getAllTasks = (name?: string) => async (
     const resp = await fetchTasks(query)
 
     let nonNormalizedTasks = resp.data.tasks
-    let next = resp.data.links.next
+    let next = resp.data?.links?.next
     while (next && next.includes('after=')) {
       const afterAndExtras = next.split('after=')
       if (afterAndExtras.length < 2) {

src/tasks/containers/TasksPage.test.tsx

@@ -14,6 +14,7 @@ import TasksPage from './TasksPage'
 import {deleteTask, patchTask, postTask, getTask} from 'src/client'
 import {parse} from 'src/languageSupport/languages/flux/parser'
 import {mocked} from 'ts-jest/utils'
+import {initialState} from 'src/tasks/reducers/helpers'
 
 const sampleScript =
   'option task = {\n  name: "beetle",\n  every: 1h,\n}\n' +
@@ -151,6 +152,7 @@ const setup = (override = {}) => {
         status: RemoteDataState.Done,
       },
       tasks: {
+        ...initialState(),
         byID: {
           [localTasks[0].id]: localTasks[0],
           [localTasks[1].id]: localTasks[1],

src/tasks/containers/TasksPage.tsx

@@ -67,10 +67,6 @@ class TasksPage extends PureComponent<Props, State> {
   constructor(props: Props) {
     super(props)
 
-    if (!props.showInactive) {
-      props.setShowInactive()
-    }
-
     this.state = {
       isImporting: false,
       taskLabelsEdit: null,