fix: bump the bytes number for cloud (#5625)

Author: asalem1

src/dataExplorer/components/ResultsPane.tsx

@@ -91,7 +91,7 @@ const ResultsPane: FC = () => {
     selection,
   } = useContext(PersistanceContext)
 
-  const submitButtonDisabled = !text || !selection.measurement
+  const submitButtonDisabled = !text && !selection.measurement
 
   const disabledTitleText = submitButtonDisabled
     ? 'Select measurement before running script'

src/shared/apis/query.ts

@@ -11,6 +11,7 @@ import {
 import {CancelBox} from 'src/types/promises'
 import {File, Query, CancellationError} from 'src/types'
 import {event} from 'src/cloud/utils/reporting'
+import {getFlagValue} from 'src/shared/utils/featureFlag'
 
 export type RunQueryResult =
   | RunQuerySuccessResult
@@ -103,12 +104,15 @@ const processSuccessResponse = async (
 
   let read = await reader.read()
 
+  const BYTE_LIMIT =
+    getFlagValue('increaseCsvLimit') ?? FLUX_RESPONSE_BYTES_LIMIT
+
   while (!read.done) {
     const text = decoder.decode(read.value)
 
     bytesRead += read.value.byteLength
 
-    if (bytesRead > FLUX_RESPONSE_BYTES_LIMIT) {
+    if (bytesRead > BYTE_LIMIT) {
       csv += trimPartialLines(text)
       didTruncate = true
       break

src/shared/contexts/query.tsx

@@ -1,4 +1,5 @@
 import React, {FC, useEffect, useRef} from 'react'
+import {useDispatch} from 'react-redux'
 import {useSelector} from 'react-redux'
 import {nanoid} from 'nanoid'
 import {parse, format_from_js_file} from '@influxdata/flux-lsp-browser'
@@ -9,14 +10,17 @@ import {FluxResult} from 'src/types/flows'
 import {propertyTime} from 'src/shared/utils/getMinDurationFromAST'
 
 // Constants
+import {FLUX_RESPONSE_BYTES_LIMIT} from 'src/shared/constants'
 import {SELECTABLE_TIME_RANGES} from 'src/shared/constants/timeRanges'
 import {
   RATE_LIMIT_ERROR_STATUS,
   RATE_LIMIT_ERROR_TEXT,
   GATEWAY_TIMEOUT_STATUS,
   REQUEST_TIMEOUT_STATUS,
 } from 'src/cloud/constants'
-import {isFlagEnabled} from 'src/shared/utils/featureFlag'
+import {isFlagEnabled, getFlagValue} from 'src/shared/utils/featureFlag'
+import {notify} from 'src/shared/actions/notifications'
+import {resultTooLarge} from 'src/shared/copy/notifications'
 
 // Types
 import {CancellationError, File} from 'src/types'
@@ -57,6 +61,35 @@ interface RequestBody {
   extern?: any
 }
 
+/*
+  Given an arbitrary text chunk of a Flux CSV, trim partial lines off of the end
+  of the text.
+
+  For example, given the following partial Flux response,
+
+            r,baz,3
+      foo,bar,baz,2
+      foo,bar,b
+
+  we want to trim the last incomplete line, so that the result is
+
+            r,baz,3
+      foo,bar,baz,2
+
+*/
+const trimPartialLines = (partialResp: string): string => {
+  let i = partialResp.length - 1
+
+  while (partialResp[i] !== '\n') {
+    if (i <= 0) {
+      return partialResp
+    }
+
+    i -= 1
+  }
+
+  return partialResp.slice(0, i + 1)
+}
 export interface QueryContextType {
   basic: (text: string, override?: QueryScope, options?: QueryOptions) => any
   query: (
@@ -485,6 +518,7 @@ const updateWindowPeriod = (
 }
 
 export const QueryProvider: FC = ({children}) => {
+  const dispatch = useDispatch()
   const pending = useRef({} as CancelMap)
   const org = useSelector(getOrg)
 
@@ -552,31 +586,34 @@ export const QueryProvider: FC = ({children}) => {
 
             let csv = ''
             let bytesRead = 0
-
+            let didTruncate = false
             let read = await reader.read()
 
+            const BYTE_LIMIT =
+              getFlagValue('increaseCsvLimit') ?? FLUX_RESPONSE_BYTES_LIMIT
+
             while (!read.done) {
-              if (!pending.current[id]) {
-                throw new CancellationError()
-              }
               const text = decoder.decode(read.value)
 
               bytesRead += read.value.byteLength
 
-              csv += text
-              read = await reader.read()
+              if (bytesRead > BYTE_LIMIT) {
+                csv += trimPartialLines(text)
+                didTruncate = true
+                break
+              } else {
+                csv += text
+                read = await reader.read()
+              }
             }
 
             reader.cancel()
-            if (pending.current[id]) {
-              delete pending.current[id]
-            }
 
             return {
               type: 'SUCCESS',
               csv,
               bytesRead,
-              didTruncate: false,
+              didTruncate,
             }
           }
 
@@ -667,6 +704,10 @@ export const QueryProvider: FC = ({children}) => {
           throw new Error(raw.message)
         }
 
+        if (raw.didTruncate) {
+          dispatch(notify(resultTooLarge(raw.bytesRead)))
+        }
+
         return raw
       })
       .then(raw => fromFlux(raw.csv))

src/shared/utils/featureFlag.ts

@@ -19,6 +19,16 @@ export const isFlagEnabled = (flagName: string, equals?: string | boolean) => {
   return false
 }
 
+export const getFlagValue = (flagName: string) => {
+  const flags = activeFlags(getStore().getState())
+
+  if (flags.hasOwnProperty(flagName)) {
+    return flags[flagName]
+  }
+
+  return null
+}
+
 // type influx.toggle('myFlag') to disable / enable any feature flag
 export const FeatureFlag: FunctionComponent<{
   name: string