fix(button): prevent unnecessary keydown/keyup handlers

Mikhail Bashkirov · Mikhail Bashkirov · commit 06124e06bf26 · 2019-07-26T16:45:49.000+02:00
diff --git a/packages/button/src/LionButton.js b/packages/button/src/LionButton.js
@@ -202,7 +202,7 @@ export class LionButton extends DisabledWithTabIndexMixin(
   }
 
   __keydownHandler(e) {
-    if (!this.__isKeyboardClickEvent(e)) {
+    if (this.active || !this.__isKeyboardClickEvent(e)) {
       return;
     }
     this.active = true;

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ export class LionButton extends DisabledWithTabIndexMixin(`
`202`	`202`	`}`
`203`	`203`
`204`	`204`	`__keydownHandler(e) {`
`205`		`- if (!this.__isKeyboardClickEvent(e)) {`
	`205`	`+ if (this.active \|\| !this.__isKeyboardClickEvent(e)) {`
`206`	`206`	`return;`
`207`	`207`	`}`
`208`	`208`	`this.active = true;`