Skip to content

Commit 364f185

Browse files
tlouissedaKmoRJoren BroekemaMikhail Bashkirov
committed
feat(overlays): release new overlay system
Co-authored-by: Thomas Allmer <Thomas.Allmer@ing.com> Co-authored-by: Joren Broekema <Joren.Broekema@ing.com> Co-authored-by: Mikhail Bashkirov <Mikhail.Bashkirov@ing.com>
1 parent e161c71 commit 364f185

37 files changed

+2889
-4254
lines changed

packages/overlays/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,8 @@ const myCtrl = overlays.add(
3333
// name OverlayTypeController is for illustration purpose only
3434
// please read below about existing classes for different types of overlays
3535
```
36+
37+
## Rationals
38+
39+
- No `aria-controls`: as support for it is not quite there yet
40+
- No `aria-haspopup` People knowing the haspop up and hear about it don’t expect a dialog to open (at this moment in time) but expect a sub-menu. Until support for the dialog value has better implementation, it’s probably best to not use aria-haspopup on the element that opens the modal dialog.

packages/overlays/index.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
export { DynamicOverlayController } from './src/DynamicOverlayController.js';
2-
export { GlobalOverlayController } from './src/GlobalOverlayController.js';
31
export { globalOverlaysStyle } from './src/globalOverlaysStyle.js';
4-
export { LocalOverlayController } from './src/LocalOverlayController.js';
5-
export { BottomSheetController } from './src/BottomSheetController.js';
6-
export { ModalDialogController } from './src/ModalDialogController.js';
72
export { overlays } from './src/overlays.js';
83
export { OverlaysManager } from './src/OverlaysManager.js';
4+
export { OverlayController } from './src/OverlayController.js';
5+
export { OverlayMixin } from './src/OverlayMixin.js';
96

10-
// deprecated
11-
export { BottomSheetController as BottomsheetController } from './src/BottomSheetController.js';
7+
export { withBottomSheetConfig } from './src/configurations/withBottomSheetConfig.js';
8+
export { withModalDialogConfig } from './src/configurations/withModalDialogConfig.js';
9+
export { withDropdownConfig } from './src/configurations/withDropdownConfig.js';

packages/overlays/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"src",
2929
"stories",
3030
"test",
31+
"test-helpers",
3132
"translations",
3233
"*.js"
3334
],
@@ -38,6 +39,7 @@
3839
"devDependencies": {
3940
"@open-wc/demoing-storybook": "^0.2.0",
4041
"@open-wc/testing": "^2.3.4",
42+
"@open-wc/testing-helpers": "^1.0.0",
4143
"sinon": "^7.2.2"
4244
}
4345
}

packages/overlays/src/BaseOverlayController.js

Lines changed: 0 additions & 281 deletions
This file was deleted.

packages/overlays/src/BottomSheetController.js

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)