Skip to content

refactor: improve tracing span usage #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2025
Merged

refactor: improve tracing span usage #22

merged 6 commits into from
Feb 20, 2025

Conversation

prestwich
Copy link
Member

Makes a few span usage changes

  • adds verbose event for param parsing failures in Level::TRACE
  • adds root spans for request and batch request handling in router
  • removes permanently-open spans for tasks
  • moves future instantiation after permit acquisition to delay resource allocation
  • adds span to BatchFuture so that all RouteFutures are inside the batch future
  • add spans that record the params before decoding, and before deserialization

@prestwich prestwich self-assigned this Feb 20, 2025
@prestwich prestwich requested a review from Evalir February 20, 2025 19:13
Evalir
Evalir approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no nits

@prestwich prestwich enabled auto-merge (rebase) February 20, 2025 21:56
@prestwich prestwich merged commit c43875d into main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

Assignees

@prestwich prestwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @Evalir