feat(config): Set SlotCalculator config with CHAIN_NAME instead of verbose values
#148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f verbose values This makes it easier to configure the builder through setting the chain name, instead of setting each calculator configuration variable. Closes ENG-1372
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
requested changes
Sep 10, 2025
|
It's runnable for any chain that the slot calculator supports through |
|
this is a significant change to builder functionality that makes it impossible to run on custom nets. is that intentional? |
|
Yes this is intentional. We want to make the builder easier to configure. Restricting the builders to chains we have the values in constants for is one way to do so. |
prestwich
approved these changes
Sep 10, 2025
|
cc @rswanson i'd like your ACK/NACK on this before we merge |
|
Alright, with the new bin-base version now having the constants is still an option, if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to configure the builder slot calculator through setting the chain name, instead of setting each slot calculator configuration variable.
Closes ENG-1372
@rswanson this will lets us load the slot calculator from the
CHAIN_NAMEenv var.This also updates signet dependencies because it's needed to use the latest
bin-base. No behavior change is expected.