Skip to content

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Sep 17, 2025

Replaces per-task spans with a single span that is passed through the env -> build -> submit tasks

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich marked this pull request as ready for review September 17, 2025 19:47
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. really wanna see how this looks in prod

@prestwich
Copy link
Member Author

cc @dylanlott I think this causes minimal rebase issues with your PR?

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are no merge conflicts since we already separated out the builder helper from the flashbots submitter tasks. 👍

@dylanlott dylanlott merged commit d83fa7d into main Sep 18, 2025
6 checks passed
@dylanlott dylanlott deleted the prestwich/span-passing branch September 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants