feat: blob cache #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested changes
Aug 5, 2025
| use signet_zenith::Zenith::BlockSubmitted; | ||
| use signet_zenith::ZenithBlock; | ||
| use std::{ | ||
| sync::{Arc, Mutex}, |
There was a problem hiding this comment.
we should use the tokio Mutex, not the std one. we want to yield back to the executor when acquiring a lock
There was a problem hiding this comment.
There was a problem hiding this comment.
ah good catch. we're only holding data so it's fine
crates/blobber/src/cache.rs
Outdated
| /// # Panics | ||
| /// This function will panic if the cache task fails to spawn. | ||
| pub fn spawn(self) -> CacheHandle { | ||
| let (sender, inst) = mpsc::channel(12); |
There was a problem hiding this comment.
this number should also be a constant
Evalir
approved these changes
Aug 5, 2025
| use signet_zenith::Zenith::BlockSubmitted; | ||
| use signet_zenith::ZenithBlock; | ||
| use std::{ | ||
| sync::{Arc, Mutex}, |
There was a problem hiding this comment.
ah good catch. we're only holding data so it's fine
prestwich
force-pushed
the
prestwich/blob-cache
branch
from
4125eb6 to
c77ae5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a blob cache that wraps a blob fetcher
this is a BREAKING change to the api
BlockExtraction->BlobFetcher