This repository was archived by the owner on Mar 26, 2025. It is now read-only.
feat(builder): retry on incorrect host block error
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Oct 25, 2024
prestwich
reviewed
Oct 25, 2024
rswanson
approved these changes
Oct 25, 2024
prestwich
reviewed
Oct 25, 2024
| break; | ||
| } | ||
| Ok(ControlFlow::Done) => { | ||
| tracing::info!("block landed successfully"); |
There was a problem hiding this comment.
need to set retries to 0 in Skip and Done arms
There was a problem hiding this comment.
pretty sure it gets reset on each iteration of the outer loop?
There was a problem hiding this comment.
oh you're right. i don't like the nested loop tho. kinda ugly and implies we should break out a function
There was a problem hiding this comment.
yep agreed, we can break it out in another PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.