fix: header event emits indexed and unindexed header

[prestwich]

indexed structs are serialized and hashed, and the original data is not included in the event. This adds a non-indexed Header struct param alongside, so that we keep access to the header data

[anna-carroll]

i think maybe let's just do non-indexed?

[prestwich]

having both allows us to still use it as a topic to find the specific event that admitted that header

[anna-carroll]

yes but i'm wondering in what circumstances we would have the exact header information beforehand and want to use it to query the event. confirmBy field in the header in particular means that there isn't a situation where we'd be able to query for a header without knowing the specific information about that header beforehand.

i'm wondering if there's a way we could serve the need of "i know about a header, i want to find the event" while also servicing other more general & useful things.

i think it would be nice to have the following indexed:

• uint256 rollupChainId;
• uint256 sequence;

perhaps we break out the header info into individual event params and index those two?

[anna-carroll]

i think it would be nice to have the following indexed:

• uint256 rollupChainId;
• uint256 sequence;

for example it would be nice to be able to say "give me all the blocks from a given chain" OR "give me all the 0th blocks that have been emitted, so i can see what chains there are"

but this would also serve the need of "i have a full header and i want to find the event" because (ruChainId, sequence) is a unique block identifier

[prestwich]

so the new would be

event BlockSubmitted(
        address indexed sequencer, uint256 indexed rollupChainId, uint256 indexed sequence, BlockHeader header, bytes32 blockDataHash
    );

ya that sounds good to me

[anna-carroll]

would we wanna do

event BlockSubmitted(
   address indexed sequencer, 
   uint256 indexed rollupChainId, 
   uint256 indexed sequence, 
   uint256 confirmBy, 
   uint256 gasLimit, 
   address rewardAddress, 
   bytes32 blockDataHash
);

just to avoid paying for re-emitting rollupChainId and sequence unnecessarily

[prestwich]

this is fine. let's ship it