Skip to content

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Mar 10, 2020

@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Mar 10, 2020
@mrBliss mrBliss requested a review from edsko March 10, 2020 14:37
@mrBliss
Copy link
Contributor Author

mrBliss commented Mar 10, 2020

Lemma 3 is harder to check, because of #1765 (comment), but also because we suddenly have ApplyTx blk and HasTxs blk constraints on applyExtLedger, which are rather annoying. Adding them as superclasses of LedgerSupportsProtocol is convenient, but annoying in ouroboros-consensus-byron, because the instances are defined in separate modules. Moreover, DualByronBlock doesn't support HasTxs, so that's a no go 🙁.

Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it :)

@edsko
Copy link
Contributor

edsko commented Mar 11, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus issues related to ouroboros-consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch the order in applyExtLedgerState

2 participants