Skip to content

Subscription Update #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2020
Merged

Subscription Update #1860

merged 2 commits into from
Mar 26, 2020

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Mar 26, 2020

Implements #1859 and fixes #1859.

@karknu karknu changed the title Karknu/sub imp Sumbscription Update Mar 26, 2020
@karknu karknu changed the title Sumbscription Update Subscription Update Mar 26, 2020
@karknu karknu marked this pull request as ready for review March 26, 2020 10:51
@karknu karknu requested review from coot and dcoutts March 26, 2020 10:51
karknu added 2 commits March 26, 2020 16:23
@karknu
Don't open unneeded connections
2d9bc2c 
When we have reached the valency goal we shouldn't open any extra
connections.
@karknu
Decrease defaultConnectionAttemptDelay to 25ms
6dc1fa8 
By decreasing the time we wait before trying a new connection from 250ms
to 25ms we make it very likely that the node will end up using a peer on
the same contenent.
dcoutts
dcoutts approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Reports are that this selects the relay on the local continent reasonably well.

@dcoutts
Copy link
Contributor

dcoutts commented Mar 26, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 26, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 690e825 into master Mar 26, 2020
@iohk-bors iohk-bors bot deleted the karknu/sub_imp branch March 26, 2020 17:06
@dcoutts
Copy link
Contributor

dcoutts commented Mar 26, 2020

Implements #1859 and fixes #1859.

Meant to say Implements #1859 and fixes #1858. Closing #1858...

@dcoutts dcoutts mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcoutts dcoutts dcoutts approved these changes

@coot coot Awaiting requested review from coot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lower the time we wait before starting a new connection.

2 participants

@karknu @dcoutts