Introduce queries about an era that can be answered in any era #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/query-anytime
branch
from
00e888f to
802bb67
Compare
Fixes #2346. * Split `HardForkQuery` up into: 1. `QueryIfCurrent`: queries about a certain era that only can be answered when the current ledger is in the respective era. 2. `QueryAnytime`: queries about a certain era that can be answered when the current ledger is in *any* era. No queries about the first era can be asked to keep the HFC with a single ledger isomorphic to just the ledger. An example query is `EraStart`, which returns the start epoch/time/slot of an era. * The pattern synonyms for `CardanoQuery` were renamed from `QueryByron` and `QueryShelley` to `QueryIfCurrentByron`, `QueryIfCurrentShelley`, and `QueryAnytimeShelley`.
mrBliss
force-pushed
the
mrBliss/query-anytime
branch
from
802bb67 to
e7bb3fd
Compare
edsko
approved these changes
Jul 1, 2020
|
bors merge |
mrBliss
added a commit
that referenced
this pull request
Jul 10, 2020
Some idiot broke backwards compatibility in #2349. We were no longer able to exchange queries via the `LocalStateQuery` protocol with a Byron-only node.
mrBliss
added a commit
that referenced
this pull request
Jul 10, 2020
Some idiot broke backwards compatibility in #2349. We were no longer able to exchange queries via the `LocalStateQuery` protocol with a Byron-only node.
iohk-bors bot
added a commit
that referenced
this pull request
Jul 10, 2020
2385: Test & fix backwards compatibility between Byron and Cardano r=mrBliss a=mrBliss Test backwards compatibility between Byron and Cardano Fixes #2361. A node running `CardanoBlock` can communicate with older nodes that run `ByronBlock`, until the hard fork happens (as the other nodes won't support Shelley). Test that we're actually backwards compatible. This test did exactly what it was supposed to do: it found a bug! Some idiot broke backwards compatibility in #2349. We were no longer able to exchange queries via the `LocalStateQuery` protocol with a Byron-only node. Fix it. Co-authored-by: Thomas Winant <thomas@well-typed.com>
iohk-bors bot
added a commit
that referenced
this pull request
Jul 10, 2020
2385: Test & fix backwards compatibility between Byron and Cardano r=mrBliss a=mrBliss Test backwards compatibility between Byron and Cardano Fixes #2361. A node running `CardanoBlock` can communicate with older nodes that run `ByronBlock`, until the hard fork happens (as the other nodes won't support Shelley). Test that we're actually backwards compatible. This test did exactly what it was supposed to do: it found a bug! Some idiot broke backwards compatibility in #2349. We were no longer able to exchange queries via the `LocalStateQuery` protocol with a Byron-only node. Fix it. Co-authored-by: Thomas Winant <thomas@well-typed.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2346.
Split
HardForkQueryup into:QueryIfCurrent: queries about a certain era that only can be answeredwhen the current ledger is in the respective era.
QueryAnytime: queries about a certain era that can be answered when thecurrent ledger is in any era. No queries about the first era can be
asked to keep the HFC with a single ledger isomorphic to just the ledger.
An example query is
EraStart, which returns the start epoch/time/slotof an era.
The pattern synonyms for
CardanoQuerywere renamed fromQueryByronandQueryShelleytoQueryIfCurrentByron,QueryIfCurrentShelley, andQueryAnytimeShelley.