Skip to content

Default bfcMaxConcurrencyDeadline should be 1 #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Default bfcMaxConcurrencyDeadline should be 1 #2457

merged 1 commit into from
Jul 23, 2020

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Jul 23, 2020

No description provided.

@karknu karknu requested review from coot and mrBliss July 23, 2020 05:36
coot
coot approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu
Copy link
Contributor Author

karknu commented Jul 23, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 23, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 98c7794 into master Jul 23, 2020
@iohk-bors iohk-bors bot deleted the karknu/deadline-default branch July 23, 2020 07:26
@mrBliss
Copy link
Contributor

mrBliss commented Jul 23, 2020

Out of curiosity, why should it be 1 instead of 2?

@karknu
Copy link
Contributor Author

karknu commented Jul 23, 2020

A bfcMaxConcurrencyDeadline > 1 is acceptable for stake pool operators that are fine with wasting some bandwidth on fetching blocks from multiple sources in order to get it as fast as possible.
The default config should be suitable for normal clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

@mrBliss mrBliss Awaiting requested review from mrBliss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karknu @mrBliss @coot