Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 11, 2025

Part of https://github.com/insightsengineering/coredev-tasks/issues/649
Companion to insightsengineering/teal.goshawk#361

Removed body of the hard-deprecated module and it's examples.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/g_boxplot.R                        116     116  0.00%    147-310
R/g_correlationplot.R                137     137  0.00%    251-421
R/g_density_distribution_plot.R       86      86  0.00%    125-236
R/g_lineplot.R                       276     276  0.00%    266-611
R/g_scatterplot.R                      5       5  0.00%    14-18
R/g_spaghettiplot.R                  101     101  0.00%    248-381
R/geom_axes_line.R                   167     167  0.00%    46-358
R/t_summarytable.R                   102     102  0.00%    87-224
R/utils.R                             70      70  0.00%    17-137
TOTAL                               1060    1060  0.00%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/g_scatterplot.R     -125    -125  +100.00%
TOTAL                 -125    -125  +100.00%

Results for commit: 95f2ba8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@npaszty
Copy link
Contributor

npaszty commented Aug 11, 2025 via email

@m7pr
Copy link
Contributor Author

m7pr commented Aug 12, 2025

@npaszty it was soft deprecated, and now we hard deprecate it.
I will remove examples, tests and the body of the function. Leaving only the lifecycle error

@m7pr m7pr requested review from donyunardi and npaszty August 12, 2025 07:14
@m7pr m7pr requested a review from gogonzo August 12, 2025 07:22
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

m7pr added a commit to insightsengineering/teal.goshawk that referenced this pull request Aug 12, 2025
Part of insightsengineering/coredev-tasks#649
Companion to insightsengineering/goshawk#267
Deprecated hard one of the modules - remove body of the module and it's
examples.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@m7pr m7pr merged commit dc8df7f into main Aug 12, 2025
27 of 28 checks passed
@m7pr m7pr deleted the lifecycle@main branch August 12, 2025 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants