Fixed the method name to get the current url #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of __call should allow using getUrl as well for this, but there is a getUrl method in AbstractWebDriver which is called instead.
guilhermeblanco
added a commit
that referenced
this pull request
Jan 20, 2014
Fixed the method name to get the current url
|
@guilhermeblanco could you tag a 1.2.2 release with the fix I submitted in this PR and the other ones merged at the same time ? |
|
Tagged as 1.2.2. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
__callshould allow usinggetUrlas well for this, but there is agetURLmethod inAbstractWebDriverwhich is called instead.