preg_replace() requires quoting, specially for PHP 7.3 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here there is a simple script showing the error and the fix applied, for better understanding: Ciao :-) |
Without this, a number of expressions fail (returning NULL),
leading to both non matches and warning/error:
Warning: preg_replace(): Compilation failed: number too big in {} quantifier at offset 6
This is specially noticeable under PHP 7.3, where the new PCRE2 engine
is more picky and has more features, but also may help some cases with
previous PHP versions, depending of the string being searched/replaced.
stronk7
added a commit
to moodlehq/php-webdriver
that referenced
this pull request
Jun 3, 2019
This applies instaclick#91 (basic php73 compatibility)
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Jun 6, 2019
It seems that instaclick/php-webdriver#91 is being ignored (in fact the repository itself doesn't show much activity). So we have decided to fork it and apply any fix able to keep our (non-marionette) runs working. Hopefully, soon, the new W3C drivers will be supported by our behat->mink stack... and we'll be able to move to it (from current JSonwire drivers). So all this will be hostory.
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Jun 6, 2019
It seems that instaclick/php-webdriver#91 is being ignored (in fact the repository itself doesn't show much activity). So we have decided to fork it and apply any fix able to keep our (non-marionette) runs working. Hopefully, soon, the new W3C drivers will be supported by our behat->mink stack... and we'll be able to move to it (from current JSonwire drivers). So all this will be hostory.
stronk7
added a commit
to stronk7/moodle
that referenced
this pull request
Jun 6, 2019
It seems that instaclick/php-webdriver#91 is being ignored (in fact the repository itself doesn't show much activity). So we have decided to fork it and apply any fix able to keep our (non-marionette) runs working. Hopefully, soon, the new W3C drivers will be supported by our behat->mink stack... and we'll be able to move to it (from current JSonwire drivers). So all this will be hostory.
kirildevlion
pushed a commit
to uhaifaelearn/moodle
that referenced
this pull request
Aug 20, 2019
It seems that instaclick/php-webdriver#91 is being ignored (in fact the repository itself doesn't show much activity). So we have decided to fork it and apply any fix able to keep our (non-marionette) runs working. Hopefully, soon, the new W3C drivers will be supported by our behat->mink stack... and we'll be able to move to it (from current JSonwire drivers). So all this will be hostory.
robocoder
added a commit
that referenced
this pull request
Sep 23, 2019
robocoder
pushed a commit
that referenced
this pull request
Sep 25, 2019
Without this, a number of expressions fail (returning NULL),
leading to both non matches and warning/error:
Warning: preg_replace(): Compilation failed: number too big in {} quantifier at offset 6
This is specially noticeable under PHP 7.3, where the new PCRE2 engine
is more picky and has more features, but also may help some cases with
previous PHP versions, depending of the string being searched/replaced.
robocoder
added a commit
that referenced
this pull request
Sep 25, 2019
robocoder
added a commit
that referenced
this pull request
Sep 25, 2019
robocoder
added a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, a number of expressions fail (returning NULL),
leading to both non matches and warning/error:
Warning: preg_replace(): Compilation failed: number too big in {} quantifier at offset 6
This is specially noticeable under PHP 7.3, where the new PCRE2 engine
is more picky and has more features, but also may help some cases with
previous PHP versions, depending of the string being searched/replaced