Add option to insert items to first free tier #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of always inserting to topmost tier
byrnedj
reviewed
Jun 8, 2023
| @@ -496,7 +499,8 @@ CacheAllocator<CacheTrait>::allocateInternal(PoolId pid, | |||
| bool fromBgThread) { | |||
| auto tid = 0; /* TODO: consult admission policy */ | |||
| for(TierId tid = 0; tid < getNumTiers(); ++tid) { | |||
| auto handle = allocateInternalTier(tid, pid, key, size, creationTime, expiryTime, fromBgThread); | |||
| bool evict = config_.insertTopTier || tid == getNumTiers() - 1; | |||
There was a problem hiding this comment.
if insertTopTier == false and we are not on the last tier, why do we not evict the data? this is what we currently do.
byrnedj
approved these changes
Jun 8, 2023
vinser52
pushed a commit
that referenced
this pull request
Jul 17, 2023
instead of always inserting to topmost tier
byrnedj
pushed a commit
that referenced
this pull request
Jul 23, 2023
instead of always inserting to topmost tier
vinser52
pushed a commit
that referenced
this pull request
Feb 29, 2024
instead of always inserting to topmost tier
vinser52
pushed a commit
that referenced
this pull request
Mar 1, 2024
instead of always inserting to topmost tier
byrnedj
pushed a commit
that referenced
this pull request
May 21, 2024
instead of always inserting to topmost tier
byrnedj
pushed a commit
that referenced
this pull request
Jun 25, 2024
instead of always inserting to topmost tier
byrnedj
pushed a commit
that referenced
this pull request
Jun 26, 2024
instead of always inserting to topmost tier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of always inserting to topmost tier
This change is