fix cuda ut bug of use_deterministic_algorithms #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
wenhuach21
reviewed
Sep 9, 2025
wenhuach21
reviewed
Sep 9, 2025
…ound into hengguo/fix_ut_0909
for more information, see https://pre-commit.ci
wenhuach21
reviewed
Sep 9, 2025
| logger.warning(f"unrecognized keys {list(kwargs.keys())} were passed. Please check them.") | ||
|
|
||
| if not disable_deterministic_algorithms: | ||
| # deprecated, default not to use torch.use_deterministic_algorithms |
wenhuach21
reviewed
Sep 9, 2025
| ) | ||
| if "CUBLAS_WORKSPACE_CONFIG" not in os.environ: | ||
| os.environ["CUBLAS_WORKSPACE_CONFIG"] = ":4096:8" | ||
| torch.use_deterministic_algorithms(True, warn_only=False) |
There was a problem hiding this comment.
if enable_deterministic_algorithms is not set, we use warn_only=Ture, which is the default behavior in our previous version, though I admit it's a quite confusing.
wenhuach21
approved these changes
Sep 10, 2025
chensuyue
pushed a commit
that referenced
this pull request
Sep 10, 2025
(cherry picked from commit 886d657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.