-
Notifications
You must be signed in to change notification settings - Fork 56
fix cuda ut bug of use_deterministic_algorithms #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bad0db2
fix cuda ut
n1ck-guo 26e6a41
fix
n1ck-guo a6a9ce1
clean
n1ck-guo d5ffa28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] de8787f
upadate
n1ck-guo 5b39e95
Merge branch 'hengguo/fix_ut_0909' of https://github.com/intel/auto-r…
n1ck-guo 6d96f27
clean
n1ck-guo 29e229a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4583ca2
Merge branch 'main' into hengguo/fix_ut_0909
wenhuach21 cca567e
set use_deterministic_algorithms with warn_only=True as default
wenhuach21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,7 +224,8 @@ def __init__( | |
to_quant_block_names: Union[str, list, None] = kwargs.pop("to_quant_block_names", None) | ||
enable_norm_bias_tuning: bool = kwargs.pop("enable_norm_bias_tuning", False) | ||
enable_quanted_input: bool = kwargs.pop("enable_quanted_input", True) | ||
disable_deterministic_algorithms = kwargs.pop("disable_deterministic_algorithms", False) | ||
disable_deterministic_algorithms = kwargs.pop("disable_deterministic_algorithms", True) | ||
enable_deterministic_algorithms = kwargs.pop("enable_deterministic_algorithms", False) | ||
static_kv_dtype = kwargs.pop("static_kv_dtype", None) | ||
device = kwargs.pop("device", None) | ||
self.quant_lm_head = kwargs.pop("quant_lm_head", False) | ||
|
@@ -234,11 +235,19 @@ def __init__( | |
|
||
if kwargs: | ||
logger.warning(f"unrecognized keys {list(kwargs.keys())} were passed. Please check them.") | ||
if "CUBLAS_WORKSPACE_CONFIG" not in os.environ: | ||
os.environ["CUBLAS_WORKSPACE_CONFIG"] = ":4096:8" | ||
# deprecated, default not to use torch.use_deterministic_algorithms | ||
if not disable_deterministic_algorithms or enable_deterministic_algorithms: | ||
if not disable_deterministic_algorithms: | ||
logger.warning( | ||
"default not use deterministic_algorithms. disable_deterministic_algorithms is deprecated," | ||
" please use enable_deterministic_algorithms instead. " | ||
) | ||
|
||
if not disable_deterministic_algorithms: | ||
if "CUBLAS_WORKSPACE_CONFIG" not in os.environ: | ||
os.environ["CUBLAS_WORKSPACE_CONFIG"] = ":4096:8" | ||
torch.use_deterministic_algorithms(True, warn_only=False) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if enable_deterministic_algorithms is not set, we use warn_only=Ture, which is the default behavior in our previous version, though I admit it's a quite confusing. |
||
else: | ||
torch.use_deterministic_algorithms(True, warn_only=True) | ||
|
||
if device is not None: | ||
logger.warning("`device` is deprecated, please use `device_map` instead") | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upper case