Skip to content
This repository was archived by the owner on Aug 25, 2024. It is now read-only.

Conversation

yashlamba
Copy link
Contributor

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2019

This pull request introduces 5 alerts and fixes 3 when merging 48976d0 into d4b2a35 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Wrong name for an argument in a call

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2019

This pull request introduces 8 alerts and fixes 3 when merging 4fa0fc8 into d4b2a35 - view on LGTM.com

new alerts:

  • 7 for Unused import
  • 1 for Wrong name for an argument in a call

fixed alerts:

  • 3 for Unused import

@yashlamba yashlamba changed the title Added base for scikit models model: scikit: Adding scikit models with dynamic config Aug 9, 2019
@yashlamba yashlamba marked this pull request as ready for review August 9, 2019 14:51
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2019

This pull request introduces 1 alert when merging f2c63a1 into d4b2a35 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          56       56           
  Lines        3421     3421           
  Branches      393      393           
=======================================
  Hits         3178     3178           
+ Misses        190      189    -1     
- Partials       53       54    +1
Impacted Files Coverage Δ
dffml/source/source.py 86.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b2a35...1d61231. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2019

This pull request introduces 1 alert when merging 1d61231 into d4b2a35 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@johnandersen777
Copy link

This pull request introduces 1 alert when merging 1d61231 into d4b2a35 - view on LGTM.com

new alerts:

* 1 for Wrong name for an argument in a call

Looks like LGTM doesn't have the keyword arguments for namedtuple correct, false positive

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants