-
Notifications
You must be signed in to change notification settings - Fork 308
Add av1 decode interfaces #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
32ce802
to
55a535c
Compare
ee2a542
to
28f25ef
Compare
va/va_dec_av1.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whey we need start_tile_idx, it's possible calc if from tile_fow tile_column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the index of the first tile in the tile group of which the current tile belongs to. The index is in raster scan order of all tiles in frame. For the first tile group, this value should be 0. This parameter can be used to uniquely identify the tile group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain more about this? Is equals to tg_start and tg_end?
If yes, why we need tile_row and tile_column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are tg_start and tg_end, and will use these names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so why we need tile_row and tile_column? can we calc it from tg_start and tg_end?
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tile_row/tile_column is tile row/column index, which is frame level , we need it since AV1 is tile based decoding, we use tile index info to verify which the current tile it is.
99ede59
to
bb383ce
Compare
6e5eaa2
to
373f2db
Compare
Sorry for interrupting. |
0c7d647
to
39044d9
Compare
As Haihao already mentioned, I would like to see the use of VASliceParameterBufferXXX instead of VABitStreamParameterBufferXXX and also |
Hi, you can see we are using VASliceParameterBufferAV1 in my latest update. |
va/va_dec_av1.h
Outdated
uint16_t cb_offset; | ||
uint8_t cr_mult; | ||
uint16_t cr_luma_mult; | ||
uint8_t cr_offset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between these fields of cr and cb, why cb_luma_mult is uint8, but cr_luma_mult is uint16? and I dont like uint8 uint16 uint8, it is better uint8 uint8 uint16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XinfengZhang
The latest version I uploaded used uint8 uint8 uint16, like,
uint8_t cb_mult;
uint8_t cb_luma_mult;
uint16_t cb_offset;
uint8_t cr_mult;
uint8_t cr_luma_mult;
uint16_t cr_offset;
Need to add va_dec_av1.h to va/meson.build file's libva_headers. We still miss that header file in system include dir when apply this patch. |
Signed-off-by: zefuli <zefu.li@intel.com>
This breaks builds that include installed va/va.h: |
yes, this patch forget adding va_dec_av1.h to va/meson.build, please help |
Actually, the header is added to meson.build in this patch, afaict. But It was not added to Makefile.am (we still use automake in CI). I fixed the automake issue in #383. Does the meson build not work for you? |
add av1 decoding api