Skip to content

Conversation

ZefuLI
Copy link
Contributor

@ZefuLI ZefuLI commented Jun 18, 2019

add av1 decoding api

@ZefuLI ZefuLI force-pushed the master branch 2 times, most recently from 32ce802 to 55a535c Compare June 18, 2019 10:09
@ZefuLI ZefuLI force-pushed the master branch 2 times, most recently from ee2a542 to 28f25ef Compare June 26, 2019 07:34
va/va_dec_av1.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whey we need start_tile_idx, it's possible calc if from tile_fow tile_column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the index of the first tile in the tile group of which the current tile belongs to. The index is in raster scan order of all tiles in frame. For the first tile group, this value should be 0. This parameter can be used to uniquely identify the tile group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain more about this? Is equals to tg_start and tg_end?
If yes, why we need tile_row and tile_column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are tg_start and tg_end, and will use these names.

Copy link
Contributor

@xuguangxin xuguangxin Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so why we need tile_row and tile_column? can we calc it from tg_start and tg_end?

thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tile_row/tile_column is tile row/column index, which is frame level , we need it since AV1 is tile based decoding, we use tile index info to verify which the current tile it is.

@ZefuLI ZefuLI force-pushed the master branch 2 times, most recently from 99ede59 to bb383ce Compare July 24, 2019 06:39
@ZefuLI ZefuLI force-pushed the master branch 2 times, most recently from 6e5eaa2 to 373f2db Compare August 14, 2019 08:04
@rosetta-jpn
Copy link
Contributor

Sorry for interrupting.
When is the estimated time of checking in this patch?

@ZefuLI ZefuLI force-pushed the master branch 3 times, most recently from 0c7d647 to 39044d9 Compare November 11, 2019 02:21
@sreerenjb
Copy link
Contributor

As Haihao already mentioned, I would like to see the use of VASliceParameterBufferXXX instead of VABitStreamParameterBufferXXX and also
%s/bit_stream_data_size/slice_data_size
%s/bit_stream_data_offset/slice_data_offset
%s/bit_stream_data_flag/slice_data_flag
Which will make life easier for the middleware implementations .Especially GStreamer using common interface for all codecs.

@ZefuLI
Copy link
Contributor Author

ZefuLI commented Dec 4, 2019

As Haihao already mentioned, I would like to see the use of VASliceParameterBufferXXX instead of VABitStreamParameterBufferXXX and also
%s/bit_stream_data_size/slice_data_size
%s/bit_stream_data_offset/slice_data_offset
%s/bit_stream_data_flag/slice_data_flag
Which will make life easier for the middleware implementations .Especially GStreamer using common interface for all codecs.

Hi, you can see we are using VASliceParameterBufferAV1 in my latest update.

va/va_dec_av1.h Outdated
uint16_t cb_offset;
uint8_t cr_mult;
uint16_t cr_luma_mult;
uint8_t cr_offset;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between these fields of cr and cb, why cb_luma_mult is uint8, but cr_luma_mult is uint16? and I dont like uint8 uint16 uint8, it is better uint8 uint8 uint16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinfengZhang
The latest version I uploaded used uint8 uint8 uint16, like,
uint8_t cb_mult;
uint8_t cb_luma_mult;
uint16_t cb_offset;
uint8_t cr_mult;
uint8_t cr_luma_mult;
uint16_t cr_offset;

@HeJunyan
Copy link
Contributor

Need to add va_dec_av1.h to va/meson.build file's libva_headers. We still miss that header file in system include dir when apply this patch.

Signed-off-by: zefuli <zefu.li@intel.com>
@XinfengZhang XinfengZhang merged commit 7eb84e4 into intel:master Mar 4, 2020
@uartie
Copy link

uartie commented Mar 4, 2020

This breaks builds that include installed va/va.h: va/va.h:4630:10: fatal error: va/va_dec_av1.h: No such file or directory. Did you forget to add an install target for va_dec_av1.h?

@HeJunyan
Copy link
Contributor

HeJunyan commented Mar 5, 2020

yes, this patch forget adding va_dec_av1.h to va/meson.build, please help

@uartie
Copy link

uartie commented Mar 5, 2020

yes, this patch forget adding va_dec_av1.h to va/meson.build, please help

Actually, the header is added to meson.build in this patch, afaict. But It was not added to Makefile.am (we still use automake in CI). I fixed the automake issue in #383. Does the meson build not work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants