remove check of vaPutSurface implementation #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyusa
reviewed
Apr 2, 2020
| CHECK_VTABLE(vaStatus, ctx, EndPicture); | ||
| CHECK_VTABLE(vaStatus, ctx, SyncSurface); | ||
| CHECK_VTABLE(vaStatus, ctx, QuerySurfaceStatus); | ||
| CHECK_VTABLE(vaStatus, ctx, PutSurface); |
There was a problem hiding this comment.
Shouldn't they just return VA_STATUS_ERROR_UNIMPLEMENTED?
There was a problem hiding this comment.
if there are no implmented, it will set vaStatus = VA_STATUS_ERROR_UNKNOWN and return at https://github.com/intel/libva/blob/master/va/va.c#L572
There was a problem hiding this comment.
There was a problem hiding this comment.
Right. What I meant is, imo, that the driver implementators should add a function that returns VA_STATUS_ERROR_UNIMPLEMENTED.
Meanwhile, returning VA_STATUS_ERROR_UNKNOWN might be misleading to the api user.
But anyway, I'm not opposing to this change. Just stating a point of view.
Fixes intel#361 some backend driver does not implement vaPutSurface Signed-off-by: Carl Zhang <carl.zhang@intel.com>
xhaihao
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361
some backend driver does not implement vaPutSurface
Signed-off-by: Carl Zhang carl.zhang@intel.com