Skip to content

[SYCL] Stream class #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2019
Merged

[SYCL] Stream class #216

merged 1 commit into from
Jun 15, 2019

Conversation

againull
Copy link
Contributor

Stream class wraps an accessor to the underlying stream buffer. Offset
in this buffer is updated atomically to allow streaming by multiple
threads safely. Current implementation is not complete. It supports
output of string, char and boolean types. Other operators are defined
with todo in the body.

Signed-off-by: Artur Gainullin artur.gainullin@intel.com

Stream class wraps an accessor to the underlying stream buffer. Offset
in this buffer is updated atomically to allow streaming by multiple
threads safely. Current implementation is not complete. It supports
output of string, char and boolean types. Other operators are defined
with todo in the body.

Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Looking forward for the next PR which adds possibility to print different data types!

Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that it is no longer necessary to change clang/lib/Sema/SemaSYCL.cpp for this.
Looks good.

defaultfloat
};

const stream_manipulator dec = stream_manipulator::dec;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that it should have been constexpr or constexpr auto. But I check in the specification and it is said like you wrote. It looks to me the specification is over-specified... Do you think it is a specification bug?

@bader bader merged commit 6540810 into intel:sycl Jun 15, 2019
vmaksimo pushed a commit to vmaksimo/llvm that referenced this pull request Jan 25, 2021
  CONFLICT (content): Merge conflict in clang/lib/Frontend/CompilerInvocation.cpp
@againull againull deleted the stream_part1 branch December 3, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants