[SYCL] FE support for optional device features. #5166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements 2 new attributes [[sycl::device_has()]]
and [[__sycl_detail__::__uses_aspects__()]]. Both attributes
accept 0 or more device aspects (cl::sycl::aspect) as arguments.
[[sycl::device_has()]] can be applied only to functions. If a
function is decorated with this attribute, !intel_declared_aspects
metadata, listing the aspects specified in attribute argument, is
added to the function metadata.
[[__sycl_detail__::__uses_aspects__()]] is an undocumented internal
attribute which can be applied to records (type declarations) and
function. If a function is decorated with this attribute,
!intel_used_aspects metadata, listing the aspects specified in
attribute argument, is added to the function metadata. If a record
is decorated with this attribute, a named metadata node
!intel_types_that_use_aspects is generated. The value of the this
metadata is a list of unnamed metadata nodes, each of which
describes one type that is decorated with this attribute. The value
of each unnamed metadata node starts with a string giving the name
of the type which is followed by a list of i32 constants, where each
constant is a value from cl::sycl::aspect enum class, telling the
numerical value of an aspect from the type's
[[sycl_detail::uses_aspects()]] attribute.
E.g.
!intel_types_that_use_aspects = !{!0, !1, !2}
!0 = !{!"class.cl::sycl::detail::half_impl::half", i32 8}
!1 = !{!"class.cl::sycl::amx_type", i32 9}
!2 = !{!"class.cl::sycl::other_type", i32 8, i32 9}
In the example above, the type cl::sycl::detail::half_impl::half uses
an aspect whose numerical value is 8 and the type cl::sycl::other_type
uses two aspects 8 and 9.
Spec:
github.com/intel/llvm/blob/sycl/sycl/doc/OptionalDeviceFeatures.md
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
elizabethandrews
requested review from
premanandrao and
smanna12
as code owners
smanna12
reviewed
Dec 16, 2021
smanna12
reviewed
Dec 16, 2021
smanna12
reviewed
Dec 17, 2021
smanna12
reviewed
Dec 17, 2021
smanna12
reviewed
Dec 17, 2021
smanna12
reviewed
Dec 17, 2021
Fznamznon
reviewed
Dec 17, 2021
gmlueck
reviewed
Dec 17, 2021
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
smanna12
reviewed
Dec 18, 2021
smanna12
reviewed
Dec 18, 2021
…rations Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
smanna12
previously approved these changes
Dec 20, 2021
gmlueck
previously approved these changes
Dec 20, 2021
Fznamznon
previously approved these changes
Dec 20, 2021
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
elizabethandrews
dismissed stale reviews from Fznamznon, gmlueck, and smanna12
via
dc49c74
smanna12
approved these changes
Dec 20, 2021
Fznamznon
approved these changes
Dec 20, 2021
|
Thanks for the reviews everyone! |
premanandrao
approved these changes
Dec 20, 2021
|
/summary:run |
|
@bader is anything holding this up? I believe I've received the required approvals and tests pass. |
elizabethandrews
added a commit
to elizabethandrews/llvm
that referenced
this pull request
Feb 8, 2022
The original implementation of this attribute in intel#5166, did not support applying the attribute on the kernel itself. This patch fixes that. The attribute can be applied to the operator method of kernel functor or on the kernel lambda. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
bader
pushed a commit
that referenced
this pull request
Feb 9, 2022
The original implementation of this attribute in #5166, did not support applying the attribute on the kernel itself. This patch fixes that. The attribute can be applied to the operator method of kernel functor or on the kernel lambda. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements 2 new attributes [[sycl::device_has()]]
and [[sycl_detail::uses_aspects()]]. Both attributes
accept 0 or more device aspects (cl::sycl::aspect) as arguments.
[[sycl::device_has()]] can be applied only to functions. If a
function is decorated with this attribute, !intel_declared_aspects
metadata, listing the aspects specified in attribute argument, is
added to the function metadata.
[[sycl_detail::uses_aspects()]] is an undocumented internal
attribute which can be applied to records (type declarations) and
function. If a function is decorated with this attribute,
!intel_used_aspects metadata, listing the aspects specified in
attribute argument, is added to the function metadata. If a record
is decorated with this attribute, a named metadata node
!intel_types_that_use_aspects is generated. The value of the this
metadata is a list of unnamed metadata nodes, each of which
describes one type that is decorated with this attribute. The value
of each unnamed metadata node starts with a string giving the name
of the type which is followed by a list of i32 constants, where each
constant is a value from cl::sycl::aspect enum class, telling the
numerical value of an aspect from the type's
[[sycl_detail::uses_aspects()]] attribute.
E.g.
!intel_types_that_use_aspects = !{!0, !1, !2}
!0 = !{!"class.cl::sycl::detail::half_impl::half", i32 8}
!1 = !{!"class.cl::sycl::amx_type", i32 9}
!2 = !{!"class.cl::sycl::other_type", i32 8, i32 9}
In the example above, the type cl::sycl::detail::half_impl::half uses
an aspect whose numerical value is 8 and the type cl::sycl::other_type
uses two aspects 8 and 9.
Spec:
github.com/intel/llvm/blob/sycl/sycl/doc/OptionalDeviceFeatures.md
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com