[SYCL] Allow [[sycl::device_has]] attribute on kernel #5503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation of this attribute in intel#5166, did not support applying the attribute on the kernel itself. This patch fixes that. The attribute can be applied to the operator method of kernel functor or on the kernel lambda. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
bader
changed the title
Fznamznon
reviewed
Feb 8, 2022
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
|
could you please stop mentioning me. I'm not involved in this project. |
Oh I'm sorry. I didn't realize I was tagging the wrong person. Thanks for letting me know! |
gmlueck
reviewed
Feb 8, 2022
premanandrao
approved these changes
Feb 8, 2022
gmlueck
approved these changes
Feb 8, 2022
|
Thanks for the reviews! |
Fznamznon
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of this attribute in
#5166, did not support
applying the attribute on the kernel itself. This patch
fixes that. The attribute can be applied to the operator
method of kernel functor or on the kernel lambda.
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com