-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIBCLC] Extend __CLC_NVVM_ATOMIC with generic AS #7221
[LIBCLC] Extend __CLC_NVVM_ATOMIC with generic AS #7221
Conversation
Fixes: #6505 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jchlanda, please, remove XFAIL mark for cuda in llvm-test-suite tests.
|
62bdb54
to
0f70d5a
Compare
/verify with intel/llvm-test-suite#1382 |
Done in: intel/llvm-test-suite#1382 |
/verify with intel/llvm-test-suite#1382 |
Failure on Windows for KernelAndProgram/kernel-bundle-merge-options-env.cpp is known and is unrelated. |
The diffs don't show it very well, but this patch extends
__CLC_NVVM_ATOMIC
macro to generate one more overload, targetting a generic address space, while at it, it also fixes a mangled name used in the implementation of__CLC_NVVM_ATOMIC_IMPL_SUBSTITUTION
.