Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLC] Extend __CLC_NVVM_ATOMIC with generic AS #7221

Merged

Conversation

jchlanda
Copy link
Contributor

The diffs don't show it very well, but this patch extends __CLC_NVVM_ATOMIC macro to generate one more overload, targetting a generic address space, while at it, it also fixes a mangled name used in the implementation of __CLC_NVVM_ATOMIC_IMPL_SUBSTITUTION.

@jchlanda jchlanda requested a review from a team as a code owner October 28, 2022 14:05
@jchlanda
Copy link
Contributor Author

Fixes: #6505

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader
Copy link
Contributor

bader commented Nov 1, 2022

@jchlanda, please, remove XFAIL mark for cuda in llvm-test-suite tests.

Unexpectedly Passed Tests (16):
  SYCL :: AtomicRef/add_generic.cpp
  SYCL :: AtomicRef/add_generic_local.cpp
  SYCL :: AtomicRef/add_generic_local_native_fp.cpp
  SYCL :: AtomicRef/add_generic_native_fp.cpp
  SYCL :: AtomicRef/and_generic.cpp
  SYCL :: AtomicRef/and_generic_local.cpp
  SYCL :: AtomicRef/exchange_generic.cpp
  SYCL :: AtomicRef/exchange_generic_local.cpp
  SYCL :: AtomicRef/or_generic.cpp
  SYCL :: AtomicRef/or_generic_local.cpp
  SYCL :: AtomicRef/sub_generic.cpp
  SYCL :: AtomicRef/sub_generic_local.cpp
  SYCL :: AtomicRef/sub_generic_local_native_fp.cpp
  SYCL :: AtomicRef/sub_generic_native_fp.cpp
  SYCL :: AtomicRef/xor_generic.cpp
  SYCL :: AtomicRef/xor_generic_local.cpp

@jchlanda
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1382

@jchlanda
Copy link
Contributor Author

@jchlanda, please, remove XFAIL mark for cuda in llvm-test-suite tests.

Unexpectedly Passed Tests (16):
  SYCL :: AtomicRef/add_generic.cpp
  SYCL :: AtomicRef/add_generic_local.cpp
  SYCL :: AtomicRef/add_generic_local_native_fp.cpp
  SYCL :: AtomicRef/add_generic_native_fp.cpp
  SYCL :: AtomicRef/and_generic.cpp
  SYCL :: AtomicRef/and_generic_local.cpp
  SYCL :: AtomicRef/exchange_generic.cpp
  SYCL :: AtomicRef/exchange_generic_local.cpp
  SYCL :: AtomicRef/or_generic.cpp
  SYCL :: AtomicRef/or_generic_local.cpp
  SYCL :: AtomicRef/sub_generic.cpp
  SYCL :: AtomicRef/sub_generic_local.cpp
  SYCL :: AtomicRef/sub_generic_local_native_fp.cpp
  SYCL :: AtomicRef/sub_generic_native_fp.cpp
  SYCL :: AtomicRef/xor_generic.cpp
  SYCL :: AtomicRef/xor_generic_local.cpp

Done in: intel/llvm-test-suite#1382

@jchlanda
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1382

@steffenlarsen
Copy link
Contributor

Failure on Windows for KernelAndProgram/kernel-bundle-merge-options-env.cpp is known and is unrelated.

@steffenlarsen steffenlarsen merged commit d6a8fd1 into intel:sycl Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants