[SYCL] Fix narrowing type conversion in marray #7372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
dm-vodopyanov
approved these changes
Nov 14, 2022
|
@intel/llvm-reviewers-runtime hello, it is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows with -Wc++-narrowing (enabled by default) known-identity test fails because initializer list has limitations and doesn't allow narrowing conversions. It may occur when e.g. we use operator~ which upgrades type. In this case check EnableIfSuitableTypes succeeds but initializer list limitations may cause compilation errors. Inserting static_cast is valid since we already have a check for allowed types.
Signed-off-by: Tikhomirova, Kseniya kseniya.tikhomirova@intel.com