Skip to content

[SYCL] Fix narrowing type conversion in marray #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022
Merged

[SYCL] Fix narrowing type conversion in marray #7372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be8ce9
[SYCL] Fix narrowing type conversion in marray
KseniyaTikhomirova Nov 11, 2022
88b9496
Restore test
KseniyaTikhomirova Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/sycl/marray.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ template <typename Type, std::size_t NumElements> class marray {
template <
typename... ArgTN, typename = EnableIfSuitableTypes<ArgTN...>,
typename = typename std::enable_if<sizeof...(ArgTN) == NumElements>::type>
constexpr marray(const ArgTN &...Args) : MData{Args...} {}
constexpr marray(const ArgTN &...Args) : MData{static_cast<Type>(Args)...} {}

constexpr marray(const marray<Type, NumElements> &Rhs) = default;

Expand Down
2 changes: 1 addition & 1 deletion sycl/test/basic_tests/known_identity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ typename std::enable_if<!std::is_same_v<T, half> && !std::is_same_v<T, float> &&
checkMarrayKnownIdentity() {
constexpr marray<T, Num> zeros(T(0));
constexpr marray<T, Num> ones(T(1));
constexpr marray<T, Num> bit_ones(T(~0));
constexpr marray<T, Num> bit_ones(~T(0));

static_assert(has_known_identity<plus<>, marray<T, Num>>::value);
static_assert(
Expand Down