[SYCL] Add runtime support for split device binaries #759
Conversation
sergey-semenov
requested review from
Fznamznon,
kbobrovs,
AGindinson and
smaslov-intel
|
TODO: add a test once the driver supports split device binaries |
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, 13 unresolved discussions (waiting on @AGindinson, @Fznamznon, @kbobrovs, @sergey-semenov, and @smaslov-intel)
sycl/doc/SYCLPluginInterface.md, line 101 at r1 (raw file):
The idea is that SYCL runtime should do as much arch-neutral tasks as possible. So for each architecture SYCL runtime could maintain a mapping from kernel name to a set of device binaries which have this kernel implemented. Those binaries are then offered via this interface to the plugin covering this architecture to select the best fit. If there is just 1 such binary (most cases), no call to piextDeviceSelectBinary is needed.
Agreed.
sycl/include/CL/sycl/detail/pi.h, line 429 at r1 (raw file):
Previously, AGindinson (Artem Gindinson) wrote…
Other declarations around this one seems to have their own formatting rules (apparently, "to look nicer"). Don't know if it matters much - just as a note
Right, let's keep each argument on its own line
|
@sergey-semenov , could you please rebase your changes? |
sergey-semenov
force-pushed
the
splitimagesupport
branch
2 times, most recently
from
9e82ee6
to
8c9fb36
Compare
sergey-semenov
force-pushed
the
splitimagesupport
branch
from
8c9fb36
to
0ec9559
Compare
sergey-semenov
force-pushed
the
splitimagesupport
branch
from
0ec9559
to
4045eaf
Compare
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
sergey-semenov
force-pushed
the
splitimagesupport
branch
from
4045eaf
to
7708c90
Compare
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
sergey-semenov
force-pushed
the
splitimagesupport
branch
3 times, most recently
from
ce3d8df
to
d46a5ce
Compare
sergey-semenov
force-pushed
the
splitimagesupport
branch
from
d46a5ce
to
b3ee21d
Compare
Should we? #860 (comment) |
|
|
||
| // OpenCL 2.1 and greater require clCreateProgramWithIL | ||
| if (pi::useBackend(pi::SYCL_BE_PI_OPENCL) && | ||
| C.get_platform().get_info<info::platform::version>() >= "2.1") |
There was a problem hiding this comment.
is this lexicographical comparison? Why it is considered reliable here? Maybe add a comment (later is OK)
| /// map from a set of kernels to the vector of images containing them and | ||
| /// coming from the module. | ||
| /// Access must be guarded by the \ref Sync::getGlobalLock() | ||
| std::map<OSModuleHandle, KernelToImgsMap> m_DeviceImages; |
There was a problem hiding this comment.
It seems like ordering of keys is not important here, so unordered_map with O(1) lookup time complexity can be used instead of map with O(log(n)). The same applies to all other maps here. Can be addressed in a separate PR.
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
sycl/include/CL/sycl/detail/program_manager/program_manager.hpp
Outdated
Show resolved
Hide resolved
This patch enables usage of multiple split device binaries per OS module (executable or shared object file). The required binary is chosen based on the entry table (filled by clang-offload-wrapper) that lists all kernels contained within. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Co-authored-by: Sergey Semenov <sergey.semenov@intel.com> Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com> Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
sergey-semenov
force-pushed
the
splitimagesupport
branch
from
499edeb
to
bf5e663
Compare
These tests are fixed by #5359
This patch enables usage of multiple split device binaries per OS
module (executable or shared object file). The required binary is
chosen based on the entry table (filled by clang-offload-wrapper)
that lists all kernels contained within.
Signed-off-by: Sergey Semenov sergey.semenov@intel.com