shared library compilation fails #24

tiagovignatti · 2013-08-21T17:07:58Z

if we use GYP_DEFINES='component=shared_library', then the compilation fails in a bunch of places. @luxtella has some ideas how to make it work -- we need to poke him.

Dependency: #165 .
Blocks: #175
Sub-Tasks: #None

ds-hwang · 2013-08-22T11:52:24Z

yeah, I'll submit pull-request soon

tiagovignatti · 2013-08-22T11:59:33Z

Thanks! BTW, before sending a pretty pull-req, I recommend we discuss the draft idea of the patch here.

tiagovignatti · 2013-08-22T12:02:09Z

(even so because ozone-wayland is broken at this moment; one chromium patch got applied upstream and broke the downstream repo but I'm working on it right now)

ds-hwang · 2013-08-22T12:04:18Z

The draft idea is simple. Export symbols if needed. That's all.

For example,
AddGLNativeLibrary() in gl_implementation.h should be exported because ozone-wayland target needs it.

tiagovignatti · 2013-08-22T12:17:00Z

right. But I don't think that's all. We need the symbols exported correctly for the targets because I think they are missing some... just give the try there :)

kalyankondapally · 2013-11-08T13:00:00Z

@ds-hwang Any update on this ?

ds-hwang · 2013-11-08T13:17:23Z

@kalyankondapally ah, I forgot. sorry. update soon :)

ds-hwang · 2013-11-08T13:28:00Z

@kalyankondapally src/ozone/patches/patch-chromium.sh fails on today chromium. could you fix it and notify me?

kalyankondapally · 2013-11-08T13:32:11Z

@ds-hwang Are you using latest Ozone-Wayland sources, we now always pin to a version of Chromium which we are in sync with.

i.e. afe69b3

ds-hwang · 2013-11-08T13:33:04Z

@kalyankondapally yes. there are many branches. master is latest?

Ya, you should be always using the master branch unless working with CrossWalk. For CrossWalk it's the stable branch.

ds-hwang · 2013-11-08T13:33:53Z

following commit is latest,

commit eab0eea
Merge: 75ded1c 3f66130
Author: kalyan kondapally kalyan.kondapally@intel.com
Date: Mon Sep 30 15:07:20 2013 -0700

Merge pull request #94 from 01org/ipc-cleanup-v2

Ipc cleanup

kalyankondapally · 2013-11-08T13:35:19Z

No, latest commit is this : e200d0b

Something is wrong on your side. You seem to be using some old sources.
We have only two branches:
1)Master -> Daily development happens here.
2)Stable -> This branch is for Cross-Walk.

ds-hwang · 2013-11-08T13:36:00Z

which branch?

ds-hwang · 2013-11-08T13:37:08Z

ah, my origin is https://github.com/tiagovignatti/ozone-wayland.git
anyway, thx

tiagovignatti · 2013-11-08T15:05:56Z

guys, please, discuss how to set the project somewhere else in IRC maybe. Thank you.

tiagovignatti · 2013-11-20T18:34:35Z

https://codereview.chromium.org/78783004/

kalyankondapally · 2013-11-25T07:44:08Z

spoke to DS about this. He said, he was able to compile it without any changes. I tried but fails to run chromium on my side.

I think the issue is that build goes fine, but during run time you can see undefined symbols (You can run ldd -d -r out/Debug/chrome to find these). I will put up a patch for this soon. So, assigning it to myself.

ds-hwang · 2013-11-25T07:48:04Z

yes, I should check if run well.

out_ozone/Release/content_shell: symbol lookup error: /media/dshwang/ExtHDD/exthdd/workspace/chromium-ozone/src/out_ozone/Release/lib/libozone.so: undefined symbol: _ZN7content14GpuProcessHost9AddFilterEPN3IPC12ChannelProxy13MessageFilterE

Thank you for investigation 👍

kalyankondapally · 2013-11-25T10:27:50Z

Ozone-Wayland changes: kalyankondapally@6a3c2ef

Chromium specific changes:

kalyankondapally@55d8c7b
2)https://codereview.chromium.org/85303003/

I am not trying to upstream 1 yet, will need to investigate more and see if this can be avoided.

ds-hwang · 2013-11-25T12:51:28Z

lgtm. I think kalyankondapally/ozone-wayland@55d8c7b is necessary.

kalyankondapally · 2013-12-01T16:23:46Z

@tiagovignatti PTAL kalyankondapally@0407c28
2)kalyankondapally@285865b
3)kalyankondapally@8f49661

kalyankondapally · 2013-12-02T18:01:46Z

1 and 2 are merged to master now.

3 is something which needs more investigation. Adding export symbol to an api when the class itself is not exported doesn't really sound right. We would need to study if we can find alternative ways to achieve the same thing.

kalyankondapally · 2013-12-02T18:02:57Z

Moving milestone as it's not that important for now.

If someone is really interested in this, temporary solution is to use kalyankondapally/ozone-wayland@8f49661

It's known by Kalyan and he will resolve it correctly. BUG=intel#24

…HFactor OzoneDisplayChannelHost, sets itself as filter with GpuProcessHost and listens to any incoming messages from GPU process. This approach works fine but we seem to be using the wrong class to do this. BrowserGPUChannelHostFactory provides the needed API interface. This CL makes changes to replace GPUProcessHost and IPC::ChannelProxy::MessageFilter usage with the API provided by BGCHFactory. Most of the changes are based on similar functionality provided by BrowserCompositorOutputSurfaceProxy. Fixes intel#165 Fixes intel#24

[17567:17567:0528/100616:ERROR:display.cc(227)] Not implemented reached in virtual void ozonewayland::WaylandDisplay::SetWidgetState(unsigned int, ui::WidgetState, unsigned int, unsigned int) SHOW 1 [17567:17606:0528/100616:WARNING:server_connection_manager.cc(296)] ServerConnectionManager forcing SYNC_AUTH_ERROR [17567:17606:0528/100616:WARNING:syncer_proto_util.cc(277)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [17567:17606:0528/100616:ERROR:get_updates_processor.cc(240)] PostClientToServerMessage() failed during GetUpdates [17567:17584:0528/100617:WARNING:backend_impl.cc(1780)] Destroying invalid entry. [17567:17567:0528/100616:FATAL:input_device.cc(216)] Check failed: input_pointer_. #0 0x7f9f01fd0a99 base::debug::StackTrace::StackTrace() #1 0x7f9f02022a33 logging::LogMessage::~LogMessage() #2 0x7f9f03337610 ozonewayland::WaylandInputDevice::SetCursorType() #3 0x7f9f0332f9c8 ozonewayland::WaylandDisplay::SetWidgetCursor() #4 0x7f9f06f07869 views::DesktopWindowTreeHostWayland::SetCursorNative() #5 0x7f9f033238ad aura::WindowTreeHost::SetCursor() #6 0x7f9f06f1da8d views::DesktopNativeCursorManager::SetCursor() #7 0x7f9f06dcdf5c wm::CursorManager::SetCursor() #8 0x7f9f06dc94d8 wm::CompoundEventFilter::UpdateCursor() #9 0x7f9f06dc99bf wm::CompoundEventFilter::OnMouseEvent() #10 0x7f9f086c0093 ui::EventHandler::OnEvent() #11 0x7f9f086bdcf1 ui::EventDispatcher::DispatchEvent() #12 0x7f9f086bdab7 ui::EventDispatcher::DispatchEventToEventHandlers() #13 0x7f9f086bd79d ui::EventDispatcher::ProcessEvent() #14 0x7f9f086bd476 ui::EventDispatcherDelegate::DispatchEventToTarget() #15 0x7f9f086bd33d ui::EventDispatcherDelegate::DispatchEvent() #16 0x7f9f0331bcbf aura::WindowEventDispatcher::DispatchMouseEnterOrExit() #17 0x7f9f0331dde1 aura::WindowEventDispatcher::PreDispatchMouseEvent() #18 0x7f9f0331c5c1 aura::WindowEventDispatcher::PreDispatchEvent() #19 0x7f9f086bd2dd ui::EventDispatcherDelegate::DispatchEvent() #20 0x7f9f086c15e7 ui::EventProcessor::OnEventFromSource() #21 0x7f9f0331d845 aura::WindowEventDispatcher::SynthesizeMouseMoveEvent() #22 0x7f9f0331fe00 base::internal::RunnableAdapter<>::Run() #23 0x7f9f0331fc87 base::internal::InvokeHelper<>::MakeItSo() #24 0x7f9f0331fab8 base::internal::Invoker<>::Run() #25 0x7f9f00e1beb9 base::Callback<>::Run() #26 0x7f9f02033288 base::MessageLoop::RunTask() #27 0x7f9f020333ac base::MessageLoop::DeferOrRunPendingTask() #28 0x7f9f020338d3 base::MessageLoop::DoWork() #29 0x7f9f01fb45ef base::MessagePumpLibevent::Run() #30 0x7f9f02032dd7 base::MessageLoop::RunHandler() #31 0x7f9f0207300a base::RunLoop::Run() #32 0x7f9f01678366 ChromeBrowserMainParts::MainMessageLoopRun() #33 0x7f9f05851634 content::BrowserMainLoop::RunMainMessageLoopParts() #34 0x7f9f058589dc content::BrowserMainRunnerImpl::Run() #35 0x7f9f0584dba8 content::BrowserMain() #36 0x7f9f01f73f75 content::RunNamedProcessTypeMain() #37 0x7f9f01f74fa1 content::ContentMainRunnerImpl::Run() #38 0x7f9f01f73439 content::ContentMain() #39 0x7f9f00d75344 ChromeMain #40 0x7f9f00d752ea main #41 0x7f9efcbc876d __libc_start_main #42 0x7f9f00d751f9 <unknown>

[17567:17567:0528/100616:ERROR:display.cc(227)] Not implemented reached in virtual void ozonewayland::WaylandDisplay::SetWidgetState(unsigned int, ui::WidgetState, unsigned int, unsigned int) SHOW 1 [17567:17606:0528/100616:WARNING:server_connection_manager.cc(296)] ServerConnectionManager forcing SYNC_AUTH_ERROR [17567:17606:0528/100616:WARNING:syncer_proto_util.cc(277)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [17567:17606:0528/100616:ERROR:get_updates_processor.cc(240)] PostClientToServerMessage() failed during GetUpdates [17567:17584:0528/100617:WARNING:backend_impl.cc(1780)] Destroying invalid entry. [17567:17567:0528/100616:FATAL:input_device.cc(216)] Check failed: input_pointer_. #0 0x7f9f01fd0a99 base::debug::StackTrace::StackTrace() intel#1 0x7f9f02022a33 logging::LogMessage::~LogMessage() intel#2 0x7f9f03337610 ozonewayland::WaylandInputDevice::SetCursorType() intel#3 0x7f9f0332f9c8 ozonewayland::WaylandDisplay::SetWidgetCursor() intel#4 0x7f9f06f07869 views::DesktopWindowTreeHostWayland::SetCursorNative() intel#5 0x7f9f033238ad aura::WindowTreeHost::SetCursor() intel#6 0x7f9f06f1da8d views::DesktopNativeCursorManager::SetCursor() intel#7 0x7f9f06dcdf5c wm::CursorManager::SetCursor() intel#8 0x7f9f06dc94d8 wm::CompoundEventFilter::UpdateCursor() intel#9 0x7f9f06dc99bf wm::CompoundEventFilter::OnMouseEvent() intel#10 0x7f9f086c0093 ui::EventHandler::OnEvent() intel#11 0x7f9f086bdcf1 ui::EventDispatcher::DispatchEvent() intel#12 0x7f9f086bdab7 ui::EventDispatcher::DispatchEventToEventHandlers() intel#13 0x7f9f086bd79d ui::EventDispatcher::ProcessEvent() intel#14 0x7f9f086bd476 ui::EventDispatcherDelegate::DispatchEventToTarget() intel#15 0x7f9f086bd33d ui::EventDispatcherDelegate::DispatchEvent() intel#16 0x7f9f0331bcbf aura::WindowEventDispatcher::DispatchMouseEnterOrExit() intel#17 0x7f9f0331dde1 aura::WindowEventDispatcher::PreDispatchMouseEvent() intel#18 0x7f9f0331c5c1 aura::WindowEventDispatcher::PreDispatchEvent() intel#19 0x7f9f086bd2dd ui::EventDispatcherDelegate::DispatchEvent() intel#20 0x7f9f086c15e7 ui::EventProcessor::OnEventFromSource() intel#21 0x7f9f0331d845 aura::WindowEventDispatcher::SynthesizeMouseMoveEvent() intel#22 0x7f9f0331fe00 base::internal::RunnableAdapter<>::Run() intel#23 0x7f9f0331fc87 base::internal::InvokeHelper<>::MakeItSo() intel#24 0x7f9f0331fab8 base::internal::Invoker<>::Run() intel#25 0x7f9f00e1beb9 base::Callback<>::Run() intel#26 0x7f9f02033288 base::MessageLoop::RunTask() intel#27 0x7f9f020333ac base::MessageLoop::DeferOrRunPendingTask() intel#28 0x7f9f020338d3 base::MessageLoop::DoWork() intel#29 0x7f9f01fb45ef base::MessagePumpLibevent::Run() intel#30 0x7f9f02032dd7 base::MessageLoop::RunHandler() intel#31 0x7f9f0207300a base::RunLoop::Run() intel#32 0x7f9f01678366 ChromeBrowserMainParts::MainMessageLoopRun() intel#33 0x7f9f05851634 content::BrowserMainLoop::RunMainMessageLoopParts() intel#34 0x7f9f058589dc content::BrowserMainRunnerImpl::Run() intel#35 0x7f9f0584dba8 content::BrowserMain() intel#36 0x7f9f01f73f75 content::RunNamedProcessTypeMain() intel#37 0x7f9f01f74fa1 content::ContentMainRunnerImpl::Run() intel#38 0x7f9f01f73439 content::ContentMain() intel#39 0x7f9f00d75344 ChromeMain intel#40 0x7f9f00d752ea main intel#41 0x7f9efcbc876d __libc_start_main intel#42 0x7f9f00d751f9 <unknown> (cherry picked from commit 374e95a)

ghost assigned kalyankondapally Nov 25, 2013

kalyankondapally mentioned this issue Nov 29, 2013

content_shell SIGSEGV, while trying to open a context menu. #145

Closed

tiagovignatti mentioned this issue Nov 29, 2013

Chromium SIGTRAPs while creating new root window #146

Closed

kalyankondapally mentioned this issue Nov 29, 2013

Chromium crashes while trying to save a page. #147

Closed

ds-hwang added a commit to ds-hwang/ozone-wayland that referenced this issue Feb 5, 2014

patches: Export GpuProcessHost::AddFilter for component build

e4f3852

It's known by Kalyan and he will resolve it correctly. BUG=intel#24

ds-hwang added a commit to ds-hwang/ozone-wayland that referenced this issue Feb 5, 2014

patches: Export GpuProcessHost::AddFilter for component build

a5bf3cd

It's known by Kalyan and he will resolve it correctly. BUG=intel#24

kalyankondapally added this to the Valentine milestone Feb 9, 2014

kalyankondapally removed this from the Easter milestone Feb 9, 2014

kalyankondapally mentioned this issue Feb 9, 2014

Use BrowserGpuChannelHostFactory to retrieve GpuProcessHost id. #165

Closed

kalyankondapally closed this as completed in 450815b Feb 10, 2014

JunghanKim mentioned this issue Oct 15, 2014

Milestone-Autumn #284

Closed

vrotenberg mentioned this issue Jan 19, 2016

Cannot run chromium! #448

Open

arrdalan mentioned this issue Feb 1, 2016

Chromium with ozone-wayland crashes on startup #450

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

shared library compilation fails #24

shared library compilation fails #24

tiagovignatti commented Aug 21, 2013

ds-hwang commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

ds-hwang commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

tiagovignatti commented Nov 8, 2013

tiagovignatti commented Nov 20, 2013

kalyankondapally commented Nov 25, 2013

ds-hwang commented Nov 25, 2013

kalyankondapally commented Nov 25, 2013

ds-hwang commented Nov 25, 2013

kalyankondapally commented Dec 1, 2013

kalyankondapally commented Dec 2, 2013

kalyankondapally commented Dec 2, 2013

shared library compilation fails #24

shared library compilation fails #24

Comments

tiagovignatti commented Aug 21, 2013

ds-hwang commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

ds-hwang commented Aug 22, 2013

tiagovignatti commented Aug 22, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

kalyankondapally commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

ds-hwang commented Nov 8, 2013

tiagovignatti commented Nov 8, 2013

tiagovignatti commented Nov 20, 2013

kalyankondapally commented Nov 25, 2013

ds-hwang commented Nov 25, 2013

kalyankondapally commented Nov 25, 2013

ds-hwang commented Nov 25, 2013

kalyankondapally commented Dec 1, 2013

kalyankondapally commented Dec 2, 2013

kalyankondapally commented Dec 2, 2013